-
Notifications
You must be signed in to change notification settings - Fork 321
On launch, go to the last visited account #1784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sm-sayedi
wants to merge
4
commits into
zulip:main
Choose a base branch
from
sm-sayedi:524-launch-last-account
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,166
−86
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
fe3a653
db test [nfc]: Factor out BoolGlobalSettings tests in its own group
sm-sayedi d4b5387
settings: Make general int global settings, so as to add without migr…
sm-sayedi dbbc80b
app: Keep IntGlobalSetting.lastVisitedAccountId up-to-date
sm-sayedi 3a6393d
app: On launch, go to the last visited account
sm-sayedi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commit 5cfd4ae, which added
BoolGlobalSettings
, included a lot of useful material that I think should be easy to propagate to this new thing:(EDIT: and I see some of these have actually been addressed in the latest revision; I'll strike out those parts. 🙂)
GlobalSettings
saying "consider whether [etc.] can do the job instead", which helps us get the most usefulness from the thing. Let's change that comment so that it also mentions the int global settingsDartdocs on(Let's also add bidirectional "See also:" notes in that class's dartdoc and inBoolGlobalSettings
and its fields.IntGlobalSettings
's.)BoolGlobalSetting
enum, and it also got this helpful-looking implementation comment:placeholderIgnore
member, though; the pseudo-setting we're adding here isn't an "experimental feature" setting and we don't plan to remove it.)Tests