Skip to content

Conversation

@yash-agarwa-l
Copy link
Contributor

@yash-agarwa-l yash-agarwa-l commented Jan 10, 2026

On iOS and macOS, use AlignmentDirectional.centerStart instead of Alignment.centerLeft for the Stack containing Unicode emoji.

This addresses a issue identified by @gnprice in this comment.

Before

LTR

LTR

RTL

RTL

After

LTR

LTR

RTL

RTL

@chrisbobbe
Copy link
Collaborator

I'm not seeing a difference between the before and after screenshots in RTL; are those the intended screenshots?

@yash-agarwa-l
Copy link
Contributor Author

Yes, the changes made no visual difference.

@gnprice
Copy link
Member

gnprice commented Jan 14, 2026

Hmm, interesting.

Does this alignment argument have any effect here? It sounds like it might not. And looking closer, I think that fits with the code: the Stack has only one non-positioned child, and I think Stack.alignment may only be relevant for aligning multiple non-positioned children to each other. The positioned child takes care of its own alignment.

… Ah, no, there's also this:

  /// Partially-positioned children, those that do not specify an alignment in a
  /// particular axis (e.g. that have neither `top` nor `bottom` set), use the
  /// alignment to determine how they should be positioned in that
  /// under-specified axis.

and the positioned child here doesn't specify its vertical alignment.

So the horizontal axis of this alignment argument has no effect, but we do need the vertical axis to be centered. Maybe Alignment.center is the cleanest thing to put here.

yash-agarwa-l added a commit to yash-agarwa-l/zulip-flutter that referenced this pull request Jan 16, 2026
The alignment argument has no effect on the horizontal axis,
so replace centerLeft with center.

Fixes the issue described here:
zulip#2069 (comment)
yash-agarwa-l added a commit to yash-agarwa-l/zulip-flutter that referenced this pull request Jan 16, 2026
The alignment argument has no effect on the horizontal axis,
so replace centerLeft with center.

Fixes the issue described here:
zulip#2069 (comment)
The alignment argument has no effect on the horizontal axis,
so replace centerLeft with center.

Fixes the issue described here:
zulip#2069 (comment)
@yash-agarwa-l
Copy link
Contributor Author

Thanks! That’s right, I’ve updated it to use Alignment.center.

@chrisbobbe chrisbobbe requested a review from gnprice January 16, 2026 22:04
@chrisbobbe chrisbobbe added the integration review Added by maintainers when PR may be ready for integration label Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration review Added by maintainers when PR may be ready for integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants