Skip to content

Conversation

@Mannatgupta666
Copy link

Label current user as username"(you)" across DM-related views.

Here are screenshots showing the changes:
Screenshot (1984)
Screenshot (1985)
Screenshot (1986)

@AshutoshKhadse23
Copy link

AshutoshKhadse23 commented Jan 14, 2026

@Mannatgupta666, refer https://zulip.readthedocs.io/en/latest/contributing/contributing.html
Also, make sure to use correct formatting, as in your pr, I can see the formatting changes too.
One more thing, CI failed you should either solve that.
And you have pushed unnecessary files too.

@Mannatgupta666
Copy link
Author

Hi, thanks for the feedback.

I’ve gone through the contributing guide and fixed the issues you pointed out. I’ve removed the unintended formatting changes and reverted the (you) label from the message list so that all widget tests pass now. I’ve also removed the unnecessary files from the PR and re-ran CI locally to ensure everything is passing.

Please let me know if there’s anything else I should adjust. Thanks for the review!

@chrisbobbe
Copy link
Collaborator

What does the contributing guide say about commits and commit messages?

add '(you)' label for self-1:1 conversations
Wrap in WidgetSpan with ExcludeSemantics so screen readers ignore it.
@Mannatgupta666 Mannatgupta666 force-pushed the issue-1320 branch 2 times, most recently from 991e460 to b09a4fc Compare January 16, 2026 13:53
@Mannatgupta666
Copy link
Author

Thanks for pointing that out! This is my first PR, and I missed the commit guide earlier. I’ve cleaned up my commits using git rebase -i so each is clear and coherent, and pushed an updated history. Commits should be minimal, self-contained, have clear messages, and pass tests (so any test updates needed by a change should be in the same commit as the original change).

CI is currently reporting analyzer warnings in lib/api/model/submessage.dart, which I didn’t modify in this PR. Could you please advise if this is a known issue on main, or how you’d like me to proceed in order to resolve the CL?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants