added semnatics to screen loaders #2093
Open
+32
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks. Before we can review this, you'll need to fix the tests that are failing. There are also a lot of extraneous changes made in this PR, which you'll need to remove. And this change will need its own test cases. For this change, I think those tests will be short. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds accessibility semantics to screen-level loading states so they are announced by screen readers instead of being silent.
Tested with TalkBack on a physical Android device. App startup, message list loading, and topic list loading are now announced correctly. iOS (VoiceOver) not tested due to lack of access to an iOS device.
Fixes #1962