Add DM action sheet, with "View profile" and "Mark conversation as read" buttons #2114

chrisbobbe · 2026-01-30T00:22:57Z

~~(This is a draft because there's an open discussion; see the "scrollable when long" screenshots and the CZO link there.)~~

The action sheet is offered in all four places mentioned in the issue:

It should be reachable by long-pressing any of these:

A DM row in the Inbox

A recipient header in the message list

The area of the message-list app bar that identifies the narrow

The "Direct messages" (recent DMs) page

Self-DM:

Light	Dark

1:1 DM:

Light	Dark

Group DM:

Light	Dark

List of users in group DM, which is scrollable when long. We might still prefer a different page for this list (#1534); see #mobile > abbreviated headings @ 💬:

Light	Dark

chrisbobbe · 2026-02-06T00:37:58Z

Updated for Alya's feedback at #mobile > abbreviated headings @ 💬:

Makes sense to me. We might want to show 4-ish lines rather than 6-ish.

Light	Dark

Also see Greg's messages, from #mobile > abbreviated headings @ 💬:

True, the scrollable headers give a way to have a long list there without it making the rest of the action sheet unwieldy.

I think it'd still be useful to have a separate page that lists the users, following Vlad's design as seen in the screenshot at the top of this thread. Notably that adds details like status, pronouns, email address, or whatever else we put in the two-line list item for a user.

But that can coexist (whenever we implement it) with having a header like this that shows the pills. The separate page could be accessed through an option in the action sheet, with a title like "Conversation member details" (the "details" part being what signals it's more than the header shows).

So, marking as ready for review.

chrisbobbe · 2026-02-07T01:36:42Z

(fixed an unused-import nit flagged by the analyzer)

rajveermalviya

Thanks @chrisbobbe! All LGTM, modulo one tiny nit.
Moving over to Greg's review.

rajveermalviya · 2026-02-09T11:57:21Z

lib/widgets/message_list.dart

          ]);

-      case DmNarrow(:var otherRecipientIds):
+      case DmNarrow(:var otherRecipientIds): {


nit: unnecessary braces?

Sure; removed for my next revision.

chrisbobbe · 2026-02-09T20:48:15Z

Thanks! Revision pushed.

gnprice

Thanks! Generally this looks great; small comments below.

gnprice · 2026-02-09T21:27:46Z

lib/widgets/action_sheet.dart

+
+    [
+      if (narrow.otherRecipientIds.isEmpty)
+        ViewProfileButton(pageContext: context,


Suggested change

ViewProfileButton(pageContext: context,

ViewProfileButton(pageContext: pageContext,

?

Ah yeah, and I notice a few existing places we made this same mistake; I'll add a commit to fix those.

gnprice · 2026-02-09T21:29:26Z

lib/widgets/action_sheet.dart

+  ];
+
+  final header = BottomSheetHeader(
+    title: switch (narrow) {


nit: call the otherRecipientIds getter once here, instead of once per case, so as to build the list just once

Suggested change

title: switch (narrow) {

title: switch (narrow.otherRecipientIds) {

In fact since there's a few other references above, probably best to pull it out as a local.

gnprice · 2026-02-09T21:40:29Z

test/widgets/action_sheet_test.dart

+    group('smoke', () {
+      group('from inbox', () {


nit: collapse the singleton group; and can be a bit more specific about what these tests cover:

Suggested change

group('smoke', () {

group('from inbox', () {

group('show from inbox', () {

Namely, they cover causing the action sheet to show and how it looks when shown, while the behavior of the buttons is left to other tests below.

gnprice · 2026-02-09T21:43:17Z

test/widgets/action_sheet_test.dart

+            ]);
+          await tester.tap(find.widgetWithText(UserChip, eg.otherUser.fullName));


This maybe deserves highlighting as a separate test case. But at a minimum give it a separate stanza and a comment line:

Suggested change

]);

await tester.tap(find.widgetWithText(UserChip, eg.otherUser.fullName));

]);

// Tapping a user in the header leads to their profile.

await tester.tap(find.widgetWithText(UserChip, eg.otherUser.fullName));

gnprice · 2026-02-09T21:49:00Z

test/widgets/action_sheet_test.dart

+        check(findInHeader(find.text('DMs with ${eg.otherUser.fullName}')))
+          .findsOne();
+        check(store.unreads.countInDmNarrow(narrow)).equals(0);
+        check(findInHeader(find.text('DMs with ${eg.otherUser.fullName}')))
+          .findsOne();


These two findInHeader checks are redundant, right?

… weren't Topic-row UI is naturally ephemeral; it could disappear if the topic ceases to exist, or you read all its messages (as in the Inbox), etc., which is why we prefer not to use its BuildContext where we could use the whole page's context instead.

Fixes zulip#1272. While working on the design update for the Inbox page, I noticed that we were well-prepared to implement the DM action sheet, including a way to show the participants of a group DM in the action sheet itself. For that, I've used a scrollable collection of user "chips" in the action-sheet header, with avatar, presence, and name. Discussion ongoing for whether we like this approach or prefer to put the users list on a separate page, as in issue zulip#1534: https://chat.zulip.org/#narrow/channel/48-mobile/topic/abbreviated.20headings/near/2366774 In this commit, the action sheet can have up to two buttons: - "View profile", for 1:1 DMs - "Mark conversation as read", if there are unreads.

…6-ish

chrisbobbe · 2026-02-09T22:15:44Z

Thanks for the review! Revision pushed.

chrisbobbe force-pushed the pr-dm-action-sheet branch from bb69505 to 40f6fe9 Compare February 6, 2026 00:37

chrisbobbe marked this pull request as ready for review February 6, 2026 00:38

chrisbobbe requested a review from rajveermalviya February 6, 2026 00:38

chrisbobbe assigned rajveermalviya Feb 6, 2026

chrisbobbe added the maintainer review PR ready for review by Zulip maintainers label Feb 6, 2026

chrisbobbe force-pushed the pr-dm-action-sheet branch from 40f6fe9 to 672f09f Compare February 7, 2026 01:36

rajveermalviya approved these changes Feb 9, 2026

View reviewed changes

rajveermalviya added integration review Added by maintainers when PR may be ready for integration and removed maintainer review PR ready for review by Zulip maintainers labels Feb 9, 2026

rajveermalviya assigned gnprice and unassigned rajveermalviya Feb 9, 2026

rajveermalviya requested a review from gnprice February 9, 2026 15:11

chrisbobbe force-pushed the pr-dm-action-sheet branch from 672f09f to d766e61 Compare February 9, 2026 20:47

gnprice reviewed Feb 9, 2026

View reviewed changes

chrisbobbe added 4 commits February 9, 2026 14:01

user [nfc]: Make a public UserChip widget, from new-DM UI

a58f9e7

action_sheet: Constrain height of group-DM pills to 4-ish lines, not …

eabc496

…6-ish

chrisbobbe force-pushed the pr-dm-action-sheet branch from d766e61 to eabc496 Compare February 9, 2026 22:15

	ViewProfileButton(pageContext: context,
	ViewProfileButton(pageContext: pageContext,

	title: switch (narrow) {
	title: switch (narrow.otherRecipientIds) {

	group('smoke', () {
	group('from inbox', () {
	group('show from inbox', () {

		]);
		await tester.tap(find.widgetWithText(UserChip, eg.otherUser.fullName));

Add DM action sheet, with "View profile" and "Mark conversation as read" buttons #2114

Are you sure you want to change the base?

Add DM action sheet, with "View profile" and "Mark conversation as read" buttons #2114

Uh oh!

Conversation

chrisbobbe commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chrisbobbe commented Feb 6, 2026

Uh oh!

chrisbobbe commented Feb 7, 2026

Uh oh!

rajveermalviya left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chrisbobbe commented Feb 9, 2026

Uh oh!

gnprice left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chrisbobbe commented Feb 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

chrisbobbe commented Jan 30, 2026 •

edited

Loading