Fix/2108 at marker styling #2122
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add single quote (') to the list of characters to be replaced with their dot-encoded equivalents. This fixes an issue where URLs containing single quotes were not correctly parsed across different platforms and messaging clients.
Fixes zulip#2105 with the behavior needed for consistent URL detection.
Updates _IconMarker in inbox.dart to use the same styling as topic_list.dart for consistency: - Size: 16 (with text scaling) instead of fixed 14 - Color: textMessage.withFadedAlpha(0.4) for consistency Fixes zulip#2108
moksha-hub
force-pushed
the
fix/2108-at-marker-styling
branch
from
b923779 to
134100e
Compare
Member
|
@moksha-hub Please see our contributing guide: You already have one PR #2115 open, which is your first PR. Please stick to a single issue at a time until your first PR has been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.