Trying web colors for mentions #2127
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deleted enum 'UserMentionType' and outdated comments. Refactored 'parseUserMention' and changed it's return type to 'MentionNode'. Refactored '_userMentionClassNameRegexp'.
…cally Fixes zulip#1259. Look up current user group name from PerAccountStore when rendering mentions, while respecting "isSilent" flag. This ensures mentions display correctly even if the user group name has been changed since the message was sent. Falls back to original HTML text when user group not found. Added 'user group mention dynamic name resolution' tests group.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary PR for trying web colors for consistency.
For details: https://chat.zulip.org/#narrow/channel/530-mobile-design/topic/mention.20colors/with/2371198
In direct messages:
In mentions narrow:
This is a temporary PR only for trying out web colors for design purposes. Some of the code in this PR has been vibe-coded. Use caution if using this PR as a reference while working on #646 and #647.