Topic link autocomplete #2137
Draft
Topic link autocomplete #2137
+823
−120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was missed when we first added the channel link autocomplete feature.
As of this commit, it's not yet possible in the app to initiate a topic link autocomplete interaction. So in the widgets code that would consume the results of such an interaction, we just throw for now, leaving that to be implemented in a later commit.
This will be used in the next commits for generating topic link syntax in the compose box when a topic is chosen from the topic autocomplete. Also, modify `channelLink` function to generate incomplete syntax in addition to the previous completed syntax. In the next commits, the new incomplete syntax will be inserted in the compose box when a channel is chosen from the channel autocomplete. This way, the topic autocomplete interaction will be readily available. The old completed syntax will be inserted to the compose box when the channel is chosen from the topic autocomplete.
In the next commit(s), we'll need the narrow field in autocomplete intent.
We already cancel out an autocomplete intent whenever the selection is expanding to the left of the intent character (e.g @ or #). To simplify this, we can start the search for the intent character from the selection start, going leftwards. This is basically NFC, but in the new approach if there's an autocomplete intent inside the selection that will be cancelled, it still keeps looking for another autocomplete intent to the left, while previously it would cancel the looking process too. I think simplifying this part of the code is worth the additional looking which is basically harmless.
For this commit we temporarily intercept the query at the AutocompleteField widget, to avoid invoking the widgets that are still unimplemented. That lets us defer those widgets' logic to a separate later commit.
From the web repo; edited in Inkscape to remove the padding around it. https://github.com/zulip/zulip/blob/052655eee/web/icons/corner-down-right.svg
Adapted from the Figma design and the web app design: https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=7953-30398&t=IeFc4HZDSNwrfGkU-0 https://chat.zulip.org/#narrow/channel/530-mobile-design/topic/topic.20link.20autocomplete/near/2370602 Fixes: zulip#124
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #124
TODO: tests
Screenshots
Screen recording
Topic.link.autocomplete.mov