msglist: Add end-of-feed whitespace; use background color from Figma #402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Or to see both the top and bottom of a message list at the same time (when there are very few messages):
|
chrisbobbe
force-pushed
the
pr-msglist-background
branch
from
31c89ec to
0ce88f0
Compare
…eached As requested by Vlad (same link as in a code comment): https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/flutter.3A.20Mark-as-read/near/1680603 Fixes: zulip#400
Instead of having its caller make the SizedBox. This way, the whitespace will be naturally included when we give the whole message list's white background color to the individual MessageItems, coming next.
This lets `colorScheme.background` (which we matched to the Figma in 21dbae1) come through in the area with the "Mark X messages as read" button, following a Figma frame: https://www.figma.com/file/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=147%3A9133&mode=dev (There's a different Figma frame that shows a stream-specific color there; more on that in the next commit.) The background color (`colorScheme.background`) will now also come through in these areas: - in the area with the "No earlier messages" text, when scrolled to the earliest messages - in the new blank space we added after the most recent message, earlier in this series of commits. Fixes: zulip#401
gnprice
force-pushed
the
pr-msglist-background
branch
from
0ce88f0 to
3b95070
Compare
|
Thanks for these fixes! Looks good — merging. @terpimost, Chris has a question for you in the last commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshots coming soon. (Both sets of screenshots were made with #399 in the branch, for no particular reason except to avoid showing an unrelated bug that might be distracting.)
Fixes: #400
Fixes: #401