sticky_header: Fix hit-testing of header #468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our `hitTestChildren` implementation wasn't using `hitTestBoxChild` correctly: it was attempting to do the job of `childMainAxisPosition`, but `hitTestBoxChild` calls `childMainAxisPosition` for itself. The implementation of `childMainAxisPosition` wasn't correct either. Fix both, and add some tests; sticky_header hadn't had any tests on its hit-test behavior. Fixes: zulip#327
chrisbobbe
approved these changes
Dec 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #327
Also enable a bit of test config that I ended up not relying on, but that should be enabled in any case.