notif: Enable autoCancel flag for summary notification #755
Conversation
rajveermalviya
force-pushed
the
summary-notif-autocancel
branch
from
6d37e7b to
6139855
Compare
rajveermalviya
changed the title
On Android 11 and lower, if autoCancel is not specified, the summary notification may linger even after all child notifications have been opened and cleared.
rajveermalviya
force-pushed
the
summary-notif-autocancel
branch
from
6139855 to
ea0144e
Compare
|
So, I tried the emulators (from Android 12 - Android 9) and turns out it's specifically the behavior on Android 11 (API 30) and lower:
It would have been great if this was documented somewhere ^^. Also the need for an integration test that would automate this and would have caught it — if it was set-up to run on multiple emulators with different Android versions. But definitely not great for each CI run, but could be good to run before each release in CI or locally. |
|
Excellent, thanks for following up and for the thorough investigation! (Previous thread for cross-reference: #703 (comment) .) Merging this. I'll also add a line in the comment, to use our pattern for marking things we can simplify away when we drop support for an old platform. (We most commonly use this for versions of the Zulip server, the
Yep. Android unfortunately isn't real consistent about documenting this sort of thing.
Yeah, agreed. I'll go file an issue or two about doing that. We're not going to invest in it soon; but I want to record this experience, because it's a great motivating example to have in mind when the launch is complete and we're thinking about what to prioritize next. |
Done: |
Great, Thanks @gnprice! |
While trying out the release build from main on a relatively older (Android 11) device, I found that it results in lingering summary notif:
android-14.mp4
android-11.mp4
Specifying
autoCancel: truefixes this behavior on the older device.