Skip to content

Fix #1506 : Improve handling of narrows (views) with no messages #1580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

sahith-ch
Copy link
Collaborator

What does this PR do, and why?

This PR improves handling of narrows with no messages by implementing a placeholder component

External discussion & connections

How did you test this?

  • Manually - Behavioral changes
  • [ x] Manually - Visual changes
  • Adapting existing automated tests
  • Adding automated tests for new behavior (or missing tests)
  • Existing automated tests should already cover this (only a refactor of tested code)

Self-review checklist for each commit

  • It is a minimal coherent idea
  • It has a commit summary following the documented style (title & body)
  • It has a commit summary describing the motivation and reasoning for the change
  • [ x] It individually passes linting and tests
  • It contains test additions for any new behavior
  • [x ] It flows clearly from a previous branch commit, and/or prepares for the next commit

Visual changes

image

@zulipbot zulipbot added the size: XL [Automatic label added by zulipbot] label Apr 8, 2025
@neiljp
Copy link
Collaborator

neiljp commented Apr 26, 2025

@Niloth-p Do you have the bandwidth to give some thoughts on this, compared to your approach in #1543 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: XL [Automatic label added by zulipbot]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve handling of narrows (views) with no messages
3 participants