Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented search bar for GIPHY #346

Closed
wants to merge 6 commits into from
Closed

Implemented search bar for GIPHY #346

wants to merge 6 commits into from

Conversation

RinsolaO
Copy link
Contributor

@RinsolaO RinsolaO commented Sep 3, 2021

Issue #314

View here -> https://zuripluginn.vercel.app/giphy

@Johndiddles is my reviewer, but I am unable to add him

@oscar-ekeyekwu
Copy link
Contributor

which app has this search bar?

Add that to the description of your PR

@RinsolaO RinsolaO changed the title Implemented search bar Implemented search bar for GIPHY Sep 3, 2021
@Davien21
Copy link
Contributor

Davien21 commented Sep 3, 2021

You're almost there, but you did not do all I wrote on the comments for your last PR.
take your time please.
@Johndiddles - make sure she gets this right
Also make sure to git pull upstream dev !!!!!!

@RinsolaO RinsolaO deleted the branch zurichat:dev September 3, 2021 08:49
@RinsolaO RinsolaO closed this Sep 3, 2021
@RinsolaO RinsolaO deleted the dev branch September 3, 2021 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants