system/process metrics #1
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvkemp
commented
Jan 13, 2025
| _(parsed.page_faults_major).must_equal(0) | ||
| _(parsed.page_faults_minor).must_equal(3832) | ||
|
|
||
| _(parsed.process_uptime).must_equal(0) if defined?(Process::CLOCK_BOOTTIME) |
zvkemp
force-pushed
the
system-metrics
branch
from
1134177 to
e4e5daf
Compare
zvkemp
force-pushed
the
system-metrics
branch
from
e4e5daf to
fc48ced
Compare
zvkemp
force-pushed
the
system-metrics
branch
from
fc48ced to
caddaab
Compare
zvkemp
force-pushed
the
system-metrics
branch
from
caddaab to
fa36e10
Compare
zvkemp
commented
Jan 23, 2025
| require 'opentelemetry-metrics-api' | ||
| rescue LoadError | ||
| end | ||
|
|
There was a problem hiding this comment.
upstream into base-metrics?
zvkemp
force-pushed
the
base-metrics
branch
5 times, most recently
from
8a538f8 to
3d758f8
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very rough draft so far; intended to be roughly equivalent to (https://opentelemetry-python-contrib.readthedocs.io/en/latest/instrumentation/system_metrics/system_metrics.html). There's some upstream async instrument work that needs to happen before any of this will work, as this is all collected out-of-band.
psbut maybe that's ok enough for now). Also not totally sure the caching strategy is viable, but the alternative would be some class that can emit multiple measurements to different instruments, but that essentially reverses the direction of data flow from what the spec says should happen.