Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

37 update input paths pre-industrial #38

Merged
merged 7 commits into from
Aug 9, 2024

Conversation

blimlim
Copy link

@blimlim blimlim commented Aug 6, 2024

This pull request updates the pre-industrial configuration with the new input paths using the restructured directory.

Note that the md5 hash for pftlookup_csiro_v16_17tiles_wtlnds.csv changed as there are slight differences between the ~access/payu and the vk83 versions of the file which but the differences don't appear to be used by the model.

Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few changes required, most of them entirely not your fault.

@blimlim
Copy link
Author

blimlim commented Aug 8, 2024

I've had a go at putting in those changes, and also swapped from the experiments to the new configuration directory. Everything looks like it's working when running a simulation with these changes.

@blimlim blimlim requested a review from aidanheerdegen August 8, 2024 01:17
Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but this also needs the module use path to be set to

     - /g/data/vk83/modules/access-models/

@blimlim blimlim requested a review from aidanheerdegen August 9, 2024 00:00
@blimlim
Copy link
Author

blimlim commented Aug 9, 2024

Good point! I've just added the new module path in.

Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks

@blimlim blimlim merged commit 6156075 into pre-industrial Aug 9, 2024
@blimlim blimlim deleted the 37-update-input-paths-pre-industrial branch August 9, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants