-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ACCESS-OM3: use per-variable checksums from mom restart files #110
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #110 +/- ##
==========================================
+ Coverage 72.77% 74.88% +2.11%
==========================================
Files 17 17
Lines 889 900 +11
==========================================
+ Hits 647 674 +27
+ Misses 242 226 -16 ☔ View full report in Codecov by Sentry. |
0f142bd
to
399e8d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't run this yet but will soon. I left a bunch of fairly inconsequential comments on the tests
I think you could leave the issue open because this only addresses MOM repro, not other components
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just confirming that I've looked at the code and everything added looks good to me. I haven't got any additional feedback that hasn't been brought up already
I ran this with access-om3 at it works as expected. Run 1: make checksums and then I copied them into testing/checksums restart repro from cold start passed and 2x1day with restart in the middle compared to 1x2 day failed, consistent with other tests |
bd3a875
to
239dd8f
Compare
@anton-seaice (and/or anyone else) could you take another look please? Once you're happy I'll tidy up the history a little before merging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dougiesquire !
tests/resources/access-om3/configurations/om3-dev-1deg_jra55do_ryf/nuopc.runconfig
Outdated
Show resolved
Hide resolved
f916cfe
to
ad126bf
Compare
ad126bf
to
dfcaa49
Compare
@anton-seaice, I tidied up the history a little. Could you please approve again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dougiesquire
This PR modifies the
AccessOm3
test class to extract per-variable checksums from MOM restart files, rather than using theocean.stats
output. This required some minor modifications to theExpTestHelper
and baseModel
test classes to allow the archive restart directories to be easily used.Relevant to #86, although doesn't actually use the Payu hashes as suggested in that issue. See COSIMA/access-om3#278 for some additional context/discussion.