test(swing-store): fix AVA teardown flake; bump ava to ^7.0.0#12667
Conversation
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s AVA test dependency to AVA 7 across root, package, and service workspaces, and adjusts swing-store AVA configuration to avoid worker-thread teardown flakes.
Changes:
- Bumps AVA devDependency ranges from
^6.4.1to^7.0.0across workspaces and updatesyarn.lock. - Widens
packages/SwingSet’s AVA peer dependency to include AVA 7. - Disables AVA worker threads for
packages/swing-store.
Reviewed changes
Copilot reviewed 52 out of 53 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
package.json |
Updates root AVA devDependency. |
yarn.lock |
Refreshes AVA 7 and transitive dependency resolutions. |
services/ymax-planner/package.json |
Updates AVA devDependency. |
packages/access-token/package.json |
Updates AVA devDependency. |
packages/agoric-cli/package.json |
Updates AVA devDependency. |
packages/async-flow/package.json |
Updates AVA devDependency. |
packages/base-zone/package.json |
Updates AVA devDependency. |
packages/boot/package.json |
Updates AVA devDependency. |
packages/builders/package.json |
Updates AVA devDependency. |
packages/cache/package.json |
Updates AVA devDependency. |
packages/casting/package.json |
Updates AVA devDependency. |
packages/client-utils/package.json |
Updates AVA devDependency. |
packages/cosmic-proto/package.json |
Updates AVA devDependency. |
packages/cosmic-swingset/package.json |
Updates AVA devDependency. |
packages/create-dapp/package.json |
Updates AVA devDependency. |
packages/deploy-script-support/package.json |
Updates AVA devDependency. |
packages/ERTP/package.json |
Updates AVA devDependency. |
packages/fast-usdc/package.json |
Updates AVA devDependency. |
packages/fast-usdc-contract/package.json |
Updates AVA devDependency. |
packages/fast-usdc-deploy/package.json |
Updates AVA devDependency. |
packages/governance/package.json |
Updates AVA devDependency. |
packages/import-manager/package.json |
Updates AVA devDependency. |
packages/inter-protocol/package.json |
Updates AVA devDependency. |
packages/internal/package.json |
Updates AVA devDependency. |
packages/kmarshal/package.json |
Updates AVA devDependency. |
packages/network/package.json |
Updates AVA devDependency. |
packages/notifier/package.json |
Updates AVA devDependency. |
packages/orchestration/package.json |
Updates AVA devDependency. |
packages/pegasus/package.json |
Updates AVA devDependency. |
packages/pola-io/package.json |
Updates AVA devDependency. |
packages/portfolio-api/package.json |
Updates AVA devDependency. |
packages/portfolio-contract/package.json |
Updates AVA devDependency. |
packages/portfolio-deploy/package.json |
Updates AVA devDependency. |
packages/smart-wallet/package.json |
Updates AVA devDependency. |
packages/solo/package.json |
Updates AVA devDependency. |
packages/spawner/package.json |
Updates AVA devDependency. |
packages/store/package.json |
Updates AVA devDependency. |
packages/swing-store/package.json |
Updates AVA and disables worker threads. |
packages/swingset-liveslots/package.json |
Updates AVA devDependency. |
packages/swingset-runner/package.json |
Updates AVA devDependency. |
packages/swingset-xsnap-supervisor/package.json |
Updates AVA devDependency. |
packages/SwingSet/package.json |
Updates AVA and widens AVA peer range. |
packages/telemetry/package.json |
Updates AVA devDependency. |
packages/time/package.json |
Updates AVA devDependency. |
packages/vat-data/package.json |
Updates AVA devDependency. |
packages/vats/package.json |
Updates AVA devDependency. |
packages/vm-config/package.json |
Updates AVA devDependency. |
packages/vow/package.json |
Updates AVA devDependency. |
packages/wallet/api/package.json |
Updates AVA devDependency. |
packages/xsnap/package.json |
Updates AVA devDependency. |
packages/xsnap-lockdown/package.json |
Updates AVA devDependency. |
packages/zoe/package.json |
Updates AVA devDependency. |
packages/zone/package.json |
Updates AVA devDependency. |
| "@endo/ses-ava": "^1.3.2", | ||
| "@fast-check/ava": "^2.0.1", | ||
| "ava": "^6.4.1", | ||
| "ava": "^7.0.0", |
turadg
force-pushed
the
ta/swing-store-flake
branch
from
813df93 to
b20c162
Compare
Dropped support for Node 18, which agoric-sdk already dropped as well. https://github.com/avajs/ava/releases/tag/v7.0.0
Swing-store CI flakes after all tests pass, with AVA exiting during teardown before the job completes. Diagnostics showed the failure is not specific to AVA 6.4.1: a focused Node 20 / NODE_V8_COVERAGE CI matrix failed with worker threads enabled on both AVA 6.4.1 and 6.4.0, while AVA 6.4.1 with workerThreads disabled passed all 20 iterations. Results from Swing-Store Diagnostics run 25888073450: - ava@6.4.1 + worker threads: 1/20 failed, exit 139 - ava@6.4.0 + worker threads: 2/20 failed, exit 139 - ava@6.4.1 + workerThreads false: 0/20 failed This matches the observed flake shape: all swing-store tests pass, then the AVA process dies during worker-thread teardown. Run swing-store AVA tests in child-process mode for this package, consistent with other Agoric packages that already disable AVA worker threads.
It's also hitting: Process completed with exit code 129.
Aligns the peer ava range with the workspace-wide ava ^7.0.0 bump. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
fast-check v4 (pulled in transitively by @fast-check/ava@^3.0.1) made
two changes that broke property tests in this repo:
- `fc.bigUint` was removed; use `fc.bigInt({ min: 0n, max })` instead.
- `fc.record` now returns null-prototype objects, which Endo pass-style
classifies as Remotables — so `harden(x)` on the raw record fails
when fields like `brand`/`value` are non-method properties. Rebuild
records as plain objects (`harden({ brand, value })`) before harden.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
turadg
force-pushed
the
ta/swing-store-flake
branch
from
677b0c2 to
e8fbe6d
Compare
turadg
added
automerge:rebase
| ], | ||
| "timeout": "2m" | ||
| "timeout": "2m", | ||
| "workerThreads": false |
There was a problem hiding this comment.
I remain convinced that reducing the parallelism would help for this package, as I suspect the underlying problem is a OOM.
There was a problem hiding this comment.
Wouldn't an OOM segfault?
| // fast-check v4's `fc.record` returns null-prototype objects, which Endo | ||
| // pass-style refuses to classify as CopyRecords. Restore `Object.prototype` | ||
| // so `harden` yields a valid CopyRecord. |
There was a problem hiding this comment.
@gibson042 @erights I thought endo accepted null prototype objects as copy record. Did that change?
There was a problem hiding this comment.
Looks like some new dep versions could be dedup.
|
I'm merging now to reduce flakiness but I may follow with another PR. Definitely if the CopyRecord comment is wrong. |
Closes #12587
Description
Three changes addressing CI flake in
packages/swing-storeand dependency alignment:test(swing-store): disable AVA worker threads— Swing-store CI flakes after all tests pass, with AVA exiting during teardown before the job completes. A focused Node 20 /NODE_V8_COVERAGECI matrix (run 25888073450) isolated the cause:ava@6.4.1+ worker threads: 1/20 failed, exit 139ava@6.4.0+ worker threads: 2/20 failed, exit 139ava@6.4.1+workerThreads: false: 0/20 failedDisable AVA worker threads for swing-store, consistent with other Agoric packages. I think we tried that before and it didn't fix it. So maybe running more instances would have gotten a failure. Still worth a try.
chore(deps): bump ava to ^7.0.0 across workspaces— AVA 7.0 dropped Node 18 support, which agoric-sdk already dropped. See https://github.com/avajs/ava/releases/tag/v7.0.0. Bump applies to all workspace packages (packages/*,services/*) plus root devDep. SwingSet'speerDependencies.avarange widened to include^7.0.0.a3p-integration/proposals/*andpackages/create-dapp/demo/contractare intentionally left pinned (not workspaces).chore(deps): bump @fast-check/ava to ^3.0.1— Aligns the peer ava range with the workspace-wide ava ^7.0.0 bump.@fast-check/ava@3.xdeclares ava^7 || ^8as a peer (see CHANGELOG); previous ranges^1.1.5(ERTP, inter-protocol) and^2.0.1(fast-usdc, fast-usdc-contract, internal, portfolio-contract) only supported ava 5/6 (see CHANGELOG_2.X.md).a3p-integration/proposals/*occurrences are intentionally left at^2.0.1.Security Considerations
None — test-only dependency bump and AVA configuration change.
Scaling Considerations
None.
Documentation Considerations
None. AVA 7 is a test-runner dep; no user-facing API impact.
Testing Considerations
The disable-worker-threads change was validated in the diagnostics CI matrix cited above.
@endo/ses-avadeclares an ava peer range that doesn't yet include^7; Yarn warns (YN0060) but this is known-benign sinceses-avaonly uses a thin slice of thetAPI.Upgrade Considerations
None.
🤖 Generated with Claude Code