Skip to content

test(swing-store): fix AVA teardown flake; bump ava to ^7.0.0 #12667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 5 commits into from
May 15, 2026
Merged

test(swing-store): fix AVA teardown flake; bump ava to ^7.0.0 #12667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
51cb8ec
chore(deps): bump ava to ^7.0.0 across workspaces
turadg May 14, 2026
f2abf36
test(swing-store): disable AVA worker threads
turadg May 14, 2026
9923227
test(boot): disable AVA worker threads
turadg May 14, 2026
513c205
chore(deps): bump @fast-check/ava to ^3.0.1
turadg May 14, 2026
e8fbe6d
test: adapt property tests to fast-check v4 API
turadg May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion a3p-integration/proposals/n:upgrade-next/yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,7 @@ __metadata:
yargs-parser: "npm:^21.1.1"
peerDependencies:
"@agoric/xsnap": "workspace:*"
ava: ^5.3.0 || ^6.0.0
ava: ^5.3.0 || ^6.0.0 || ^7.0.0
bin:
vat: bin/vat
languageName: node
Expand Down
2 changes: 1 addition & 1 deletion a3p-integration/proposals/z:acceptance/yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,7 @@ __metadata:
yargs-parser: "npm:^21.1.1"
peerDependencies:
"@agoric/xsnap": "workspace:*"
ava: ^5.3.0 || ^6.0.0
ava: ^5.3.0 || ^6.0.0 || ^7.0.0
bin:
vat: bin/vat
languageName: node
Expand Down
2 changes: 1 addition & 1 deletion multichain-testing/yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,7 +559,7 @@ __metadata:
yargs-parser: "npm:^21.1.1"
peerDependencies:
"@agoric/xsnap": "workspace:*"
ava: ^5.3.0 || ^6.0.0
ava: ^5.3.0 || ^6.0.0 || ^7.0.0
bin:
vat: bin/vat
languageName: node
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"@types/express": "^4.17.17",
"@types/node": "~22.9.0",
"@yarnpkg/types": "^4.0.1",
"ava": "^6.4.1",
"ava": "^7.0.0",
Comment thread
turadg marked this conversation as resolved.
"c8": "^10.1.3",
"conventional-changelog-conventionalcommits": "^9.1.0",
"dprint": "^0.53.0",
Expand Down
4 changes: 2 additions & 2 deletions packages/ERTP/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,8 @@
"devDependencies": {
"@agoric/swingset-vat": "workspace:*",
"@endo/bundle-source": "^4.1.2",
"@fast-check/ava": "^1.1.5",
"ava": "^6.4.1",
"@fast-check/ava": "^3.0.1",
"ava": "^7.0.0",
"tsd": "^0.33.0"
},
"files": [
Expand Down
5 changes: 4 additions & 1 deletion packages/ERTP/test/unitTests/amountProperties.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,10 @@ const arbBagContents = fc
.nat(7)
.chain(size =>
fc.array(
fc.tuple(fc.string(), fc.bigUint({ max: 1_000_000_000_000_000n })),
fc.tuple(
fc.string(),
fc.bigInt({ min: 0n, max: 1_000_000_000_000_000n }),
),
{ minLength: size, maxLength: size },
),
)
Expand Down
4 changes: 2 additions & 2 deletions packages/SwingSet/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"@types/microtime": "^2.1.0",
"@types/tmp": "^0.2.0",
"@types/yargs-parser": "^21.0.0",
"ava": "^6.4.1"
"ava": "^7.0.0"
},
"dependencies": {
"@agoric/internal": "workspace:*",
Expand Down Expand Up @@ -66,7 +66,7 @@
},
"peerDependencies": {
"@agoric/xsnap": "workspace:*",
"ava": "^5.3.0 || ^6.0.0"
"ava": "^5.3.0 || ^6.0.0 || ^7.0.0"
},
"files": [
"bin/vat",
Expand Down
2 changes: 1 addition & 1 deletion packages/access-token/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"devDependencies": {
"@types/n-readlines": "^1.0.3",
"@types/proper-lockfile": "^4.1.2",
"ava": "^6.4.1",
"ava": "^7.0.0",
"c8": "^10.1.3"
},
"files": [
Expand Down
2 changes: 1 addition & 1 deletion packages/agoric-cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"devDependencies": {
"@agoric/cosmic-swingset": "workspace:*",
"@agoric/deploy-script-support": "workspace:*",
"ava": "^6.4.1",
"ava": "^7.0.0",
"c8": "^10.1.2"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/async-flow/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
"@agoric/swingset-vat": "workspace:*",
"@agoric/zone": "workspace:*",
"@endo/env-options": "^1.1.11",
"ava": "^6.4.1",
"ava": "^7.0.0",
"tsd": "^0.33.0"
},
"publishConfig": {
Expand Down
2 changes: 1 addition & 1 deletion packages/base-zone/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"devDependencies": {
"@endo/init": "^1.1.12",
"@endo/ses-ava": "^1.3.2",
"ava": "^6.4.1"
"ava": "^7.0.0"
},
"publishConfig": {
"access": "public"
Expand Down
1 change: 1 addition & 0 deletions packages/boot/ava.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,4 +81,5 @@ export default {
require: ['@endo/init/debug.js'],
timeout: '20m',
sortTestFiles: byExplicitBootOrder,
workerThreads: false,
};
2 changes: 1 addition & 1 deletion packages/boot/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
"@agoric/store": "workspace:*",
"@agoric/swingset-liveslots": "workspace:*",
"@endo/base64": "^1.0.12",
"ava": "^6.4.1",
"ava": "^7.0.0",
"c8": "^10.1.3",
"ts-blank-space": "^0.6.2"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/builders/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
"@agoric/swingset-vat": "workspace:*",
"@agoric/time": "workspace:*",
"@endo/errors": "^1.2.13",
"ava": "^6.4.1",
"ava": "^7.0.0",
"c8": "^10.1.3"
},
"files": [
Expand Down
2 changes: 1 addition & 1 deletion packages/cache/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
},
"devDependencies": {
"@agoric/zoe": "workspace:*",
"ava": "^6.4.1",
"ava": "^7.0.0",
"c8": "^10.1.3"
},
"files": [
Expand Down
2 changes: 1 addition & 1 deletion packages/casting/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
"devDependencies": {
"@agoric/cosmic-proto": "workspace:*",
"@endo/ses-ava": "^1.3.2",
"ava": "^6.4.1",
"ava": "^7.0.0",
"c8": "^10.1.3",
"express": "^5.0.1",
"tsd": "^0.33.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/client-utils/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"@agoric/vats": "workspace:*",
"@agoric/zoe": "workspace:*",
"@hyperweb/telescope": "^2.2.1",
"ava": "^6.4.1",
"ava": "^7.0.0",
"c8": "^10.1.3",
"rimraf": "^6.0.1",
"ts-blank-space": "^0.6.2"
Expand Down
2 changes: 1 addition & 1 deletion packages/cosmic-proto/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@
"@endo/bundle-source": "^4.1.2",
"@endo/import-bundle": "^1.5.2",
"@hyperweb/telescope": "^2.2.1",
"ava": "^6.4.1",
"ava": "^7.0.0",
"esbuild": "^0.25.2",
"rimraf": "^5.0.0",
"tsd": "^0.33.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/cosmic-swingset/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
},
"devDependencies": {
"@agoric/kmarshal": "workspace:*",
"ava": "^6.4.1",
"ava": "^7.0.0",
"better-sqlite3": "^10.1.0",
"c8": "^10.1.3",
"execa": "^9.5.2"
Expand Down
2 changes: 1 addition & 1 deletion packages/create-dapp/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"lint:types": "yarn run -T tsc"
},
"devDependencies": {
"ava": "^6.4.1",
"ava": "^7.0.0",
"c8": "^10.1.3"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/deploy-script-support/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
"devDependencies": {
"@agoric/vats": "workspace:*",
"@endo/init": "^1.1.12",
"ava": "^6.4.1",
"ava": "^7.0.0",
"import-meta-resolve": "^4.1.0"
},
"files": [
Expand Down
4 changes: 2 additions & 2 deletions packages/fast-usdc-contract/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@
"@agoric/swingset-liveslots": "workspace:*",
"@agoric/vats": "workspace:*",
"@agoric/zone": "workspace:*",
"@fast-check/ava": "^2.0.1",
"ava": "^6.4.1",
"@fast-check/ava": "^3.0.1",
"ava": "^7.0.0",
Comment thread
turadg marked this conversation as resolved.
"c8": "^10.1.3",
"execa": "^9.5.2",
"tinyspy": "^4.0.3",
Expand Down
2 changes: 1 addition & 1 deletion packages/fast-usdc-deploy/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"@agoric/swing-store": "workspace:*",
"@agoric/vats": "workspace:*",
"@endo/promise-kit": "^1.1.13",
"ava": "^6.4.1",
"ava": "^7.0.0",
"c8": "^10.1.3",
"esbuild": "^0.25.2",
"execa": "^9.5.2",
Expand Down
4 changes: 2 additions & 2 deletions packages/fast-usdc/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@
"lint:types": "yarn run -T tsc"
},
"devDependencies": {
"@fast-check/ava": "^2.0.1",
"ava": "^6.4.1",
"@fast-check/ava": "^3.0.1",
"ava": "^7.0.0",
Comment thread
turadg marked this conversation as resolved.
"c8": "^10.1.3",
"nano-spawn": "^1.0.2",
"ts-blank-space": "^0.6.2"
Expand Down
10 changes: 8 additions & 2 deletions packages/fast-usdc/test/pool-share-math.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,19 +216,25 @@ const logAmt = amt => [
.replace(/ brand]$/, ''),
];

// fast-check v4's `fc.record` returns null-prototype objects, which Endo
// pass-style refuses to classify as CopyRecords. Restore `Object.prototype`
// so `harden` yields a valid CopyRecord.
Comment on lines +219 to +221

@mhofman mhofman May 15, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gibson042 @erights I thought endo accepted null prototype objects as copy record. Did that change?

@gibson042 gibson042 May 15, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, that was dropped in 2022: endojs/endo#1324

const asCopyRecord = <T extends object>(x: T) =>
harden(Object.setPrototypeOf(x, Object.prototype));

const arbAmountOf = brand =>
fc
.record({
brand: fc.constant(brand),
value: fc.bigInt({ min: 1n, max: 1_000n * 1_000_000n }),
})
.map(x => harden(x));
.map(asCopyRecord);
const arbUSDC = arbAmountOf(brands.USDC);
const arbShares = arbAmountOf(brands.PoolShares);

const arbShareWorth = fc
.record({ numerator: arbUSDC, denominator: arbShares })
.map(x => harden(x));
.map(asCopyRecord);

testProp(
'deposit properties',
Expand Down
2 changes: 1 addition & 1 deletion packages/governance/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
"@agoric/swingset-vat": "workspace:*",
"@endo/bundle-source": "^4.1.2",
"@endo/init": "^1.1.12",
"ava": "^6.4.1",
"ava": "^7.0.0",
"c8": "^10.1.3"
},
"files": [
Expand Down
2 changes: 1 addition & 1 deletion packages/import-manager/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"homepage": "https://github.com/Agoric/agoric-sdk#readme",
"devDependencies": {
"@agoric/swingset-vat": "workspace:*",
"ava": "^6.4.1",
"ava": "^7.0.0",
"c8": "^10.1.3"
},
"files": [
Expand Down
4 changes: 2 additions & 2 deletions packages/inter-protocol/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@
"@endo/bundle-source": "^4.1.2",
"@endo/init": "^1.1.12",
"@endo/promise-kit": "^1.1.13",
"@fast-check/ava": "^1.1.5",
"ava": "^6.4.1",
"@fast-check/ava": "^3.0.1",
"ava": "^7.0.0",
"c8": "^10.1.3",
"deep-object-diff": "^1.1.9",
"import-meta-resolve": "^4.1.0"
Expand Down
4 changes: 2 additions & 2 deletions packages/internal/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@
"@endo/exo": "^1.5.12",
"@endo/init": "^1.1.12",
"@endo/ses-ava": "^1.3.2",
"@fast-check/ava": "^2.0.1",
"ava": "^6.4.1",
"@fast-check/ava": "^3.0.1",
"ava": "^7.0.0",
Comment thread
turadg marked this conversation as resolved.
"tsd": "^0.33.0"
},
"ava": {
Expand Down
2 changes: 1 addition & 1 deletion packages/kmarshal/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"devDependencies": {
"@endo/init": "^1.1.12",
"@endo/ses-ava": "^1.3.2",
"ava": "^6.4.1"
"ava": "^7.0.0"
},
"publishConfig": {
"access": "public"
Expand Down
2 changes: 1 addition & 1 deletion packages/network/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"@agoric/vow": "workspace:*",
"@agoric/zone": "workspace:*",
"@endo/bundle-source": "^4.1.2",
"ava": "^6.4.1",
"ava": "^7.0.0",
"c8": "^10.1.3"
},
"exports": {
Expand Down
2 changes: 1 addition & 1 deletion packages/notifier/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
"@agoric/swingset-vat": "workspace:*",
"@endo/init": "^1.1.12",
"@endo/ses-ava": "^1.3.2",
"ava": "^6.4.1",
"ava": "^7.0.0",
"c8": "^10.1.3"
},
"exports": {
Expand Down
2 changes: 1 addition & 1 deletion packages/orchestration/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
"@endo/bundle-source": "^4.1.2",
"@endo/import-bundle": "^1.5.2",
"@endo/ses-ava": "^1.3.2",
"ava": "^6.4.1",
"ava": "^7.0.0",
"c8": "^10.1.3",
"esbuild": "^0.25.2",
"prettier": "^3.7.4",
Expand Down
2 changes: 1 addition & 1 deletion packages/pegasus/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
},
"devDependencies": {
"@agoric/vat-data": "workspace:*",
"ava": "^6.4.1",
"ava": "^7.0.0",
"c8": "^10.1.3",
"import-meta-resolve": "^4.1.0"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/pola-io/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"@agoric/internal": "workspace:*"
},
"devDependencies": {
"ava": "^6.4.1"
"ava": "^7.0.0"
},
"files": [
"src/"
Expand Down
2 changes: 1 addition & 1 deletion packages/portfolio-api/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"devDependencies": {
"@types/js-yaml": "^4",
"ajv": "^6.12.6",
"ava": "^6.4.1",
"ava": "^7.0.0",
"c8": "^10.1.3",
"js-yaml": "^4.1.1",
"ts-blank-space": "^0.6.2",
Expand Down
4 changes: 2 additions & 2 deletions packages/portfolio-contract/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@
"@endo/init": "^1.1.12",
"@endo/promise-kit": "^1.1.13",
"@endo/ses-ava": "^1.3.2",
"@fast-check/ava": "^2.0.1",
"ava": "^6.4.1",
"@fast-check/ava": "^3.0.1",
"ava": "^7.0.0",
"c8": "^10.1.3",
"ts-blank-space": "^0.6.2"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/portfolio-deploy/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
"@cosmjs/crypto": "^0.36.0",
"@cosmjs/proto-signing": "^0.36.0",
"@noble/hashes": "~1.5.0",
"ava": "^6.4.1",
"ava": "^7.0.0",
"c8": "^10.1.3",
"esbuild": "^0.25.2",
"execa": "^9.5.2",
Expand Down
2 changes: 1 addition & 1 deletion packages/smart-wallet/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"@endo/bundle-source": "^4.1.2",
"@endo/captp": "^4.4.8",
"@endo/init": "^1.1.12",
"ava": "^6.4.1",
"ava": "^7.0.0",
"import-meta-resolve": "^4.1.0"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/solo/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
"devDependencies": {
"@agoric/ertp": "workspace:*",
"@endo/bundle-source": "^4.1.2",
"ava": "^6.4.1",
"ava": "^7.0.0",
"c8": "^10.1.3"
},
"publishConfig": {
Expand Down
Loading
Loading