Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make repo locking more flexible #33

Merged
merged 8 commits into from
Feb 15, 2025

Conversation

revati-naik-apex
Copy link
Collaborator

@revati-naik-apex revati-naik-apex commented Feb 13, 2025

Fixed the hard-coded paths in the repo locking functionality that always pointed to @ros2_config external workspace.

User now has an option to provide the config workspace name.

@revati-naik-apex revati-naik-apex linked an issue Feb 13, 2025 that may be closed by this pull request
@revati-naik-apex revati-naik-apex self-assigned this Feb 13, 2025
@revati-naik-apex revati-naik-apex force-pushed the 31-make-repo-locking-more-flexible branch from 31b9f25 to e95d54c Compare February 13, 2025 22:27
@revati-naik-apex
Copy link
Collaborator Author

@kilian-funk-apexai This is ready for your review.

@revati-naik-apex revati-naik-apex force-pushed the 31-make-repo-locking-more-flexible branch from 534963f to 7985e39 Compare February 13, 2025 22:51
@revati-naik-apex revati-naik-apex force-pushed the 31-make-repo-locking-more-flexible branch from 7985e39 to 832c6c2 Compare February 14, 2025 21:23
Copy link
Collaborator

@kilian-funk-apexai kilian-funk-apexai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still see a 0001-Remove-hardcoded-paths-from-rules_ros-config-impleme.patch file in the PR. Not sure if that is a browser update issue on my side.

Looks good to me with the minor change requests.

@revati-naik-apex
Copy link
Collaborator Author

I still see a 0001-Remove-hardcoded-paths-from-rules_ros-config-impleme.patch file in the PR. Not sure if that is a browser update issue on my side.

Looks good to me with the minor change requests.

@kilian-funk-apexai Done. it is ready for your review again.

@kilian-funk-apexai kilian-funk-apexai merged commit 5f8a15d into main Feb 15, 2025
2 checks passed
@kilian-funk-apexai kilian-funk-apexai deleted the 31-make-repo-locking-more-flexible branch February 15, 2025 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make repo locking more flexible
2 participants