-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make repo locking more flexible #33
Conversation
31b9f25
to
e95d54c
Compare
@kilian-funk-apexai This is ready for your review. |
534963f
to
7985e39
Compare
7985e39
to
832c6c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still see a 0001-Remove-hardcoded-paths-from-rules_ros-config-impleme.patch
file in the PR. Not sure if that is a browser update issue on my side.
Looks good to me with the minor change requests.
@kilian-funk-apexai Done. it is ready for your review again. |
Fixed the hard-coded paths in the repo locking functionality that always pointed to
@ros2_config
external workspace.User now has an option to provide the config workspace name.