-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for MAV_CMD_DO_SET_ROI_WPNEXT_OFFSET #23092
base: master
Are you sure you want to change the base?
Add support for MAV_CMD_DO_SET_ROI_WPNEXT_OFFSET #23092
Conversation
cc338e1
to
3b9aaec
Compare
nice to see all these gimbal related enhancements! I'm not sure how much use the DO_SET_ROI_WPNEXT_OFFSET command will get but I added that issue because Don from QGC dev said there were some mapping related features that wouldn't work in AP without these. |
7b8c18d
to
13f64d8
Compare
81ebb49
to
61e3d73
Compare
46df94d
to
45780a5
Compare
This looks pretty good to me but it seems like maybe only the Gremsy and Servo gimbals are supported? We should add support for all gimbals really. I'm slightly surprised (but not really) that we need a new gimbal mode to do this but I think this is essentially an existing issue that will only be fixed by moving the mode handling up into the backend code... that's beyond the scope of this PR though so if we can at least get all the other backends to support this new mode then I'm happy. |
e8e5740
to
cded4f7
Compare
cded4f7
to
4226ed7
Compare
There's a request for this feature here in the forums. https://discuss.ardupilot.org/t/viewpro-gimbal-point-camera-here-function/98279/27 |
4226ed7
to
93ca7e7
Compare
93ca7e7
to
1a3eb07
Compare
Closes #7658
I've only tested this as far as QGC can upload a site-scan mission and the vehicle seems to run it through to completion.I have not made sure the gimbal actually tracks the next waypoint location properly...Now includes a simple autotest.
The the way this waypoint works seems to be pretty straight forward in its use by sitescan. The vehicle flies parallel to a polygon defining the structure. The gimbal is instructed to point towards the next waypoint - but with a 90-degree yaw - so pointing at the structure. In the case of a circular structure the craft follows a regular polygon approximating a circle - so I would imagine that the gimbal would not keep the circular building centered in the frame.
I think this functionality could probably reasonably be put behind a define....