Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for MAV_CMD_DO_SET_ROI_WPNEXT_OFFSET #23092

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

peterbarker
Copy link
Contributor

@peterbarker peterbarker commented Mar 3, 2023

Closes #7658

I've only tested this as far as QGC can upload a site-scan mission and the vehicle seems to run it through to completion.

I have not made sure the gimbal actually tracks the next waypoint location properly...

Now includes a simple autotest.

The the way this waypoint works seems to be pretty straight forward in its use by sitescan. The vehicle flies parallel to a polygon defining the structure. The gimbal is instructed to point towards the next waypoint - but with a 90-degree yaw - so pointing at the structure. In the case of a circular structure the craft follows a regular polygon approximating a circle - so I would imagine that the gimbal would not keep the circular building centered in the frame.

I think this functionality could probably reasonably be put behind a define....

@peterbarker peterbarker added the WIP label Mar 3, 2023
@peterbarker peterbarker force-pushed the pr/MAV_CMD_DO_SET_ROI_WPNEXT_OFFSET branch 2 times, most recently from cc338e1 to 3b9aaec Compare March 7, 2023 12:06
@rmackay9
Copy link
Contributor

rmackay9 commented Mar 7, 2023

nice to see all these gimbal related enhancements! I'm not sure how much use the DO_SET_ROI_WPNEXT_OFFSET command will get but I added that issue because Don from QGC dev said there were some mapping related features that wouldn't work in AP without these.

@peterbarker peterbarker force-pushed the pr/MAV_CMD_DO_SET_ROI_WPNEXT_OFFSET branch 2 times, most recently from 7b8c18d to 13f64d8 Compare April 17, 2023 22:22
@rmackay9 rmackay9 mentioned this pull request Jun 8, 2023
43 tasks
@peterbarker peterbarker force-pushed the pr/MAV_CMD_DO_SET_ROI_WPNEXT_OFFSET branch from 81ebb49 to 61e3d73 Compare August 1, 2023 01:04
@peterbarker peterbarker force-pushed the pr/MAV_CMD_DO_SET_ROI_WPNEXT_OFFSET branch 2 times, most recently from 46df94d to 45780a5 Compare October 10, 2023 22:56
@rmackay9
Copy link
Contributor

This looks pretty good to me but it seems like maybe only the Gremsy and Servo gimbals are supported? We should add support for all gimbals really.

I'm slightly surprised (but not really) that we need a new gimbal mode to do this but I think this is essentially an existing issue that will only be fixed by moving the mode handling up into the backend code... that's beyond the scope of this PR though so if we can at least get all the other backends to support this new mode then I'm happy.

@peterbarker peterbarker force-pushed the pr/MAV_CMD_DO_SET_ROI_WPNEXT_OFFSET branch 4 times, most recently from e8e5740 to cded4f7 Compare October 11, 2023 23:51
@peterbarker peterbarker force-pushed the pr/MAV_CMD_DO_SET_ROI_WPNEXT_OFFSET branch from cded4f7 to 4226ed7 Compare October 24, 2023 22:34
@rmackay9
Copy link
Contributor

rmackay9 commented Feb 9, 2024

There's a request for this feature here in the forums. https://discuss.ardupilot.org/t/viewpro-gimbal-point-camera-here-function/98279/27

@peterbarker peterbarker force-pushed the pr/MAV_CMD_DO_SET_ROI_WPNEXT_OFFSET branch from 4226ed7 to 93ca7e7 Compare February 12, 2025 23:19
@peterbarker peterbarker force-pushed the pr/MAV_CMD_DO_SET_ROI_WPNEXT_OFFSET branch from 93ca7e7 to 1a3eb07 Compare February 12, 2025 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copter, Rover: add support for DO_SET_ROI_LOCATION
2 participants