Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AP_Scripting: update so mavlink init intent matches behavior #29254

Merged
merged 1 commit into from
Feb 8, 2025
Merged

AP_Scripting: update so mavlink init intent matches behavior #29254

merged 1 commit into from
Feb 8, 2025

Conversation

tpwrules
Copy link
Contributor

@tpwrules tpwrules commented Feb 8, 2025 •
edited
Loading

RX message ID buffer sizes have been shrunk to the amount actually used.

Followup to #29246

@tpwrules tpwrules requested a review from IamPete1 February 8, 2025 18:06
IamPete1
IamPete1 reviewed Feb 8, 2025
View reviewed changes
Copy link
Member

@IamPete1 IamPete1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to do this extra fixup. I was slightly on the fence, just because presumably the existing examples have been tested and I didn't want to re-test. But I'm 99% sure this is fine.

libraries/AP_Scripting/applets/follow-target-send.lua Outdated Show resolved Hide resolved
libraries/AP_Scripting/applets/mount-poi.lua Outdated Show resolved Hide resolved
@tpwrules
AP_Scripting: update so mavlink init intent matches behavior
1533227 
RX message ID buffer sizes have been shrunk to the amount actually used.
@tpwrules tpwrules force-pushed the pr/scripting-mavlink-init-fix branch from 43ca87c to 1533227 Compare February 8, 2025 18:22
@tpwrules
Copy link
Contributor Author

tpwrules commented Feb 8, 2025

I figure the benefit is to avoid confusing people down the line.

IamPete1
IamPete1 approved these changes Feb 8, 2025
View reviewed changes
Copy link
Member

@IamPete1 IamPete1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tpwrules tpwrules merged commit 962616a into ArduPilot:master Feb 8, 2025
101 checks passed
@tpwrules tpwrules deleted the pr/scripting-mavlink-init-fix branch February 8, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IamPete1 IamPete1 IamPete1 approved these changes

Assignees
No one assigned
Labels
Scripting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tpwrules @IamPete1