Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AC_AttitudeControl: AC_PosControl: do not constrain stopping distance velocity #29285

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

peterbarker
Copy link
Contributor

constraining our stopping distance against our configured velocity makes no sense; we may be travelling *significantly* faster than our wpnav velocity when asked to calculate a stopping point.

The constraint was added in this commit:

commit 92e05e8c4f88335abac014f2d29856297b105656
Author: Leonard Hall <[email protected]>
Date:   Sat Apr 17 01:23:14 2021 +0930

    AC_AttitudeControl: PosControl fixes

@peterbarker peterbarker requested a review from lthall February 13, 2025 02:30
… velocity

constraining our stopping distance against our configured velocity makes no sense; we may be travelling *significantly* faster than our wpnav velocity when asked to calculate a stopping point.
@peterbarker peterbarker force-pushed the pr/copter-rtl-stopping-distance-fix branch from 9604868 to 1b29468 Compare February 13, 2025 03:48
Copy link
Contributor

@lthall lthall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original reason this was added was to limit how far the aircraft would deliberatly travel if traveling much faster than the vel max.

At the time some members of the dev team were conserned that the aircraft would take much longer to stop than the operator expected.

The default acceleration is 1m/ss. Traveling at 20m/s gives us a stopping distance of 200m.

This limits the maximum stopping distance to what is normally seen in RTL or Auto.

@rmackay9
Copy link
Contributor

rmackay9 commented Feb 15, 2025

I agree with @lthall's comments. I wonder if it would help to change the constraint so that it is the maximum of the RTL_SPEED and WPNAV_SPEED. Maybe @peterbarker saw this issue in a report where the RTL_SPEED was set very low.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants