Mark many functions for storage in external flash #29290
+30
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyp1per
reviewed
Feb 13, 2025
| @@ -9,7 +9,7 @@ const float AP_Declination::SAMPLING_MAX_LAT = 90; | |||
| const float AP_Declination::SAMPLING_MIN_LON = -180; | |||
| const float AP_Declination::SAMPLING_MAX_LON = 180; | |||
|
|
|||
| const float AP_Declination::declination_table[LAT_TABLE_SIZE][LON_TABLE_SIZE] = { | |||
| __EXTFLASHFUNC__ const float AP_Declination::declination_table[LAT_TABLE_SIZE][LON_TABLE_SIZE] = { | |||
There was a problem hiding this comment.
Typicall data tables might go in a different area - do we know these are only accessed at startup?
There was a problem hiding this comment.
These aren't just used at startup.
But I believe they're used at very low rates - of the order of 1 or 2Hz.
And probably quite rapidly while doing mag field calibrations.
... implying they can go into external flash
... implying they can go into external flash
Yeah, I was feeling bad about that. But I wasn't feeling bad enough about it to pull the patches out separately. Will do so now :-) |
... implying they can go into external flash
... implying they can go into external flash
... implying they can go into external flash
... implying they can go into external flash
... implying they can go into external flash
... implying they can go into external flash
... implying they can go into external flash
... implying they can go into external flash
... implying they can go into external flash
... implying they can go into external flash
... implying they can go into external flash
... implying they can go into external flash
... implying they can go into external flash
... implying they can go into external flash
... implying they can go into external flash
peterbarker
force-pushed
the
pr/__INITFUNC__
branch
from
4bb32aa to
ffca128
Compare
peterbarker
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new INITFUNC for marking processes, inferring they can be put into external flash segments.
This walks CubeRedPrimary back from the edge a bit.