[Backport 4.6] Create separate option for bridging mcast and hw can #29297
+5,731
−5,676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also change to IsForwardedFrame from IsMAVCAN
also add option to enable multicast with bridging to CAN bus in application and disabled in bootloader
bugobliterator
force-pushed
the
pr-bridge-option-mcast-backport-4.6
branch
from
dc6a7f7 to
8dbec1a
Compare
|
Thanks very much for this! I guess it's been tested to some extent? I'm not really qualified to review this but maybe we could get an approval from @tridge, @tpwrules, @peterbarker or someone else who is more familiar with this part of the code? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of this PR #28913