Fix promise and add timeout for more resilience #99403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Link to live branch is being generated... |
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
ilyasfoo
force-pushed
the
fix/woo-signup-e2e-more-resilient
branch
from
4117c23 to
e1ad8dd
Compare
ilyasfoo
commented
Feb 6, 2025
| this.page.waitForURL( /.*woocommerce\.com*/, { waitUntil: 'networkidle' } ), | ||
| this.page.waitForResponse( /.*new\?.*/ ), | ||
| const [ response ] = await Promise.all( [ | ||
| this.page.waitForResponse( /.*users\/new\?.*/ ), |
There was a problem hiding this comment.
More specific to the API URL to avoid potential future breakage due to new being too generic
matticbot
added
the
[Status] Needs Review
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
packages/calypso-e2e/src/lib/pages/signup/user-signup-page.ts
Dismissed
Show dismissed
Hide dismissed
packages/calypso-e2e/src/lib/pages/signup/user-signup-page.ts
Dismissed
Show dismissed
Hide dismissed
chihsuan
approved these changes
Feb 6, 2025
github-actions
bot
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to p1738774264455659/1738772766.101499-slack-C02DQP0FP
Proposed Changes
This PR adds a timeout in conjunction with wait. I suspect there are periods when signup takes more than 10 seconds which is the default timeout.
Testing Instructions
Pre-Release E2E Tests should pass
To test locally:
yarn workspace wp-e2e-tests test test/e2e/specs/onboarding/signup__woo-email.tsPre-merge Checklist