Reduce match init complexity #1454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I'll figure out why the test is failing. |
Member
|
Looks good to me. |
drvinceknight
approved these changes
Nov 12, 2024
marcharper
reviewed
Nov 29, 2024
|
|
||
| self.match_attributes = match_attributes | ||
| if match_attributes is None: | ||
| # known_turns = inf if both prob_end and turns are None, else turns |
Member
There was a problem hiding this comment.
This seems inconsistent with the above, no? If both are None then it should be DEFAULT_TURNS.
Also, do we need to repeat the logic here or can we just use self.turns?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few minor changes to improve readability on Match init: