Fix createAzureCommunicationCallWithChatAdapterFromClients for breakout rooms #5683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llWithChatAdapterFromClients so that a new ChatAdapter can be created when joining a breakout room
mgamis-msft
requested review from
JamesBurnside,
alkwa-msft,
dmceachernmsft,
carocao-msft,
edwardlee-msft,
prabhjot-msft,
jimchou-dev,
vhuseinova-msft,
Leah-Xia-Microsoft,
jpeng-ms,
waynemo,
emlynmac,
JoshuaLai and
palatter
dmceachernmsft
approved these changes
Mar 5, 2025
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-txbzftcnsd.chromatic.com/ |
@azure/communication-react jest test coverage for stable.
|
@azure/communication-react jest test coverage for beta.
|
JamesBurnside
approved these changes
Mar 5, 2025
…hatAdapterFromClients
Chat bundle size is not changed.
|
CallWithChat bundle size is not changed.
|
Calling bundle size is not changed.
|
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-nkmfodkbdx.chromatic.com/ |
mgamis-msft
deleted the
mgamis/fix-createAzureCommunicationCallWithChatAdapterFromClients
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Ensure createChatAdapterCallback is set for AzureCommunicationCallWithChatAdapter in
createAzureCommunicationCallWithChatAdapterFromClientsso that a new ChatAdapter can be created when joining a breakout roomWhy
To resolve #5675
How Tested
I tested using
createAzureCommunicationCallWithChatAdapterFromClientsto create a CallWithChatAdapter for a CallWithChatComposite in the quickstarts repo and first verified I got the same error in the issue above:Unable to create chat adapter for thread because createChatAdapterCallback is not set at AzureCommunicationCallWithChatAdapter.createNewChatAdapterForThreadI then tested this branch by packaging the communication-react package for the quickstarts repo and verified that the error was resolved and a new ChatAdapter was created when joining a breakout room
Process & policy checklist
Is this a breaking change?