Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix createAzureCommunicationCallWithChatAdapterFromClients for breakout rooms #5683

Merged
merged 4 commits into from
Mar 5, 2025
Merged

Fix createAzureCommunicationCallWithChatAdapterFromClients for breakout rooms #5683

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9fb67cf
Ensure createChatAdapterCallback is set in createAzureCommunicationCa…
mgamis-msft Mar 4, 2025
64d8ec1
Change files
mgamis-msft Mar 5, 2025
7bace57
remove unnecessary CC
mgamis-msft Mar 5, 2025
ea84c99
Merge branch 'main' into mgamis/fix-createAzureCommunicationCallWithC…
mgamis-msft Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions change-beta/@azure-communication-react-ae4dd794-8396-42ec-b246-234e9dfc7214.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"type": "patch",
"area": "fix",
"workstream": "Breakout rooms",
"comment": "Ensure createChatAdapterCallback is set for AzureCommunicationCallWithChatAdapter in createAzureCommunicationCallWithChatAdapterFromClients so that a new ChatAdapter can be created when joining a breakout room",
"packageName": "@azure/communication-react",
"email": "[email protected]",
"dependentChangeType": "patch"
}
9 changes: 9 additions & 0 deletions change/@azure-communication-react-ae4dd794-8396-42ec-b246-234e9dfc7214.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"type": "patch",
"area": "fix",
"workstream": "Breakout rooms",
"comment": "Ensure createChatAdapterCallback is set for AzureCommunicationCallWithChatAdapter in createAzureCommunicationCallWithChatAdapterFromClients so that a new ChatAdapter can be created when joining a breakout room",
"packageName": "@azure/communication-react",
"email": "[email protected]",
"dependentChangeType": "patch"
}
8 changes: 7 additions & 1 deletion ...tes/src/composites/CallWithChatComposite/adapter/AzureCommunicationCallWithChatAdapter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1471,7 +1471,13 @@ export const createAzureCommunicationCallWithChatAdapterFromClients = async ({
callAdapterOptions
);
const chatAdapter = await createAzureCommunicationChatAdapterFromClient(chatClient, chatThreadClient);
return new AzureCommunicationCallWithChatAdapter(callAdapter, chatAdapter);
/* @conditional-compile-remove(breakout-rooms) */
const callWithChatAdapter = new AzureCommunicationCallWithChatAdapter(callAdapter, chatAdapter);
/* @conditional-compile-remove(breakout-rooms) */
callWithChatAdapter.setCreateChatAdapterCallback((threadId: string) =>
createAzureCommunicationChatAdapterFromClient(chatClient, chatClient.getChatThreadClient(threadId))
);
return callWithChatAdapter;
};

/**
Expand Down
Loading