Skip to content
This repository was archived by the owner on Jul 30, 2025. It is now read-only.

Conversation

@LuiggiTenorioK
Copy link
Member

In GitLab by @kinow on Oct 9, 2024, 14:46

Closes BSC-ES/autosubmit#2505

cc @mandresm, @Hussam-Turjman. The code is not working yet, but just added a simple test, and the provenance.py from ESM tools. Tomorrow we can discuss briefly just where/how the provenance is hooked into the existing ruamel parsers/loaders (if we have time for that). Feel free to take over this MR and add/edit commits 👍

@mandresm
Copy link

Hi @LuiggiTenorioK, I'm happy to help with this. When you say tomorrow meeting, do you mean the 23rd of October? I could have time for a meeting indeed. What time would it work for you?

@kinow
Copy link
Member

kinow commented Oct 22, 2024

Hi @LuiggiTenorioK, I'm happy to help with this. When you say tomorrow meeting, do you mean the 23rd of October? I could have time for a meeting indeed. What time would it work for you?

Hi Miguel!

Sorry the confusion. We migrated the code from GitLab to GitHub, and the person running the import process becomes the OP of every issue and pull request.

What happened here is that @LuiggiTenorioK ran the tool, and it looks like he's commenting, but the comment above was mine, from the week of the hackathon 🙂 We can discuss about it later, but for now we are just moving things around. Sorry for the spam!

One repo migrated, over next days will migrate GUI and API, and in December when it's quieter we will handle Autosubmit... then it will be time for the great automation work to commence!!! ⚙️ 👨‍🔧

@dbeltrankyl
Copy link
Contributor

Any updates for this one?

@dbeltrankyl
Copy link
Contributor

Any updates for this one?

I just commented because the last update is from 22 October

@mandresm
Copy link

mandresm commented Feb 6, 2025

Hi @dbeltrankyl, I will have a look at it today or tomorrow. One important thing: we just realized that with this approach we cannot serialize the WithProvenance objects following the standard ways (pickling them for example is not possible). We are working in a solution. We will keep you posted.

@dbeltrankyl
Copy link
Contributor

dbeltrankyl commented Feb 6, 2025

Thanks Miguel!, there is no need for rush we're in the Autosubmit meeting revising PR, issues etc

@mandresm
Copy link

mandresm commented Feb 6, 2025

Yes, but is a very nice to have feature. I'm though not super happy about the serialization issue, I would say we should not merge until we have a solution for that, it will create problems in the future.

@mandresm
Copy link

mandresm commented Mar 3, 2025

I cannot review this ATM and I would recommend that this is merged in a more calmed period. In principle, this should not make any problems, but since we are subclassing objects from the configuration recursive methods operating on them might lead to unpredictable lengthy computations or excessive memory consumption. The serialization issue has been solved, though but I still need to get in contact with the person that solved it.

@kinow kinow marked this pull request as draft March 12, 2025 12:10
@kinow kinow changed the title Draft: GL-11: Adding provenance/attribution from ESM tools GL-11: Adding provenance/attribution from ESM tools Mar 12, 2025
@kinow
Copy link
Member

kinow commented Mar 12, 2025

Sounds good to me, @mandresm . The code was still a WIP, and it needs some further work. It was a draft on GitLab but I didn't mark it as a draft in GitHub (just did so). Thanks!

@kinow
Copy link
Member

kinow commented Jul 30, 2025

Migrated to new/old repo: BSC-ES/autosubmit#2523

@kinow kinow closed this Jul 30, 2025
@kinow kinow deleted the gl-11-yaml-provenance branch July 30, 2025 10:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Yaml provenance

5 participants