-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visible/Non Visible Specifier Changes #214
Conversation
Going to wait for #213 to be merged in, so I can merge in main and fix the formatting check. |
Co-authored-by: Daniel Fremont <[email protected]>
…ify/Scenic into VisibleSpecifierChanges
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #214 +/- ##
==========================================
+ Coverage 85.89% 86.15% +0.26%
==========================================
Files 144 144
Lines 24767 24938 +171
==========================================
+ Hits 21274 21486 +212
+ Misses 3493 3452 -41 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall: a few comments above, but mostly minor.
One other thing that I couldn't leave as a comment: the docs for the visible
and not visible
specifiers should now list regionContainedIn
as a dependency. (Arguably it's an implementation detail, not really part of the semantics, but it is a real dependency so we should probably document it.)
Co-authored-by: Daniel Fremont <[email protected]>
…ify/Scenic into VisibleSpecifierChanges
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, just a few last nitpicks.
Co-authored-by: Daniel Fremont <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great -- thanks Eric for persevering through this long review process!
The
visible
/non visible
specifiers now specify position considering the whole occupied space rather than just the position. For example, this meansvisible
can place objects that have a corner visible, andnot visible
can place objects that are behind walls.