forked from valkey-io/valkey-glide
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update jedis sync client with thread pooling #86
Merged
acarbonetto
merged 8 commits into
java/integ_acarbo_jedi_threadpool
from
java/dev_acarbo_jedi_threadpool
Feb 16, 2024
Merged
Update jedis sync client with thread pooling #86
acarbonetto
merged 8 commits into
java/integ_acarbo_jedi_threadpool
from
java/dev_acarbo_jedi_threadpool
Feb 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yury-Fridlyand
requested changes
Feb 13, 2024
java/benchmarks/src/main/java/glide/benchmarks/clients/jedis/JedisClient.java
Outdated
Show resolved
Hide resolved
java/examples/src/main/java/glide/examples/clients/GlideClient.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
ab9013d
to
46896e6
Compare
1dc2483
to
26e7a0b
Compare
Yury-Fridlyand
approved these changes
Feb 15, 2024
Signed-off-by: Andrew Carbonetto <[email protected]>
82be845
into
java/integ_acarbo_jedi_threadpool
10 checks passed
Yury-Fridlyand
pushed a commit
that referenced
this pull request
Feb 27, 2024
* Update jedis sync client with thread pooling (#86) * Add jedis threadpool for standalone client Signed-off-by: Andrew Carbonetto <[email protected]> --------- Signed-off-by: Andrew Carbonetto <[email protected]> * Java-Jedis: Only set the pool for standalone Signed-off-by: Andrew Carbonetto <[email protected]> * Spotless Signed-off-by: Andrew Carbonetto <[email protected]> * Rename field in jedis client Signed-off-by: Andrew Carbonetto <[email protected]> --------- Signed-off-by: Andrew Carbonetto <[email protected]>
cyip10
pushed a commit
that referenced
this pull request
Jun 24, 2024
* Update jedis sync client with thread pooling (#86) * Add jedis threadpool for standalone client Signed-off-by: Andrew Carbonetto <[email protected]> --------- Signed-off-by: Andrew Carbonetto <[email protected]> * Java-Jedis: Only set the pool for standalone Signed-off-by: Andrew Carbonetto <[email protected]> * Spotless Signed-off-by: Andrew Carbonetto <[email protected]> * Rename field in jedis client Signed-off-by: Andrew Carbonetto <[email protected]> --------- Signed-off-by: Andrew Carbonetto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
Fixed:
Also tested using standalone cluster.