Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jedis sync client with thread pooling #86

Merged

Conversation

acarbonetto
Copy link

@acarbonetto acarbonetto commented Feb 13, 2024

Before:

Exception in thread "main" java.lang.RuntimeException: java.util.concurrent.ExecutionException: redis.clients.jedis.exceptions.JedisConnectionException: java.net.SocketException: Broken pipe
        at glide.benchmarks.utils.Benchmarking.testClientSetGet(Benchmarking.java:163)
        at glide.benchmarks.BenchmarkingApp.main(BenchmarkingApp.java:51)
Caused by: java.util.concurrent.ExecutionException: redis.clients.jedis.exceptions.JedisConnectionException: java.net.SocketException: Broken pipe

Fixed:

> ./install_and_test.sh -$CLIENT -tasks 1 10 100 1000 -data $DATASIZE -clients 1 -host $HOST -tls -is-cluster;

...

 =====> Jedis <===== 1 clients 1000 concurrent 100 data size 

Runtime s: 273.788191
Iterations: 10000000
TPS: 36524.584858
===> GET_EXISTING <===
avg. time ms: 0.000405
std dev ms: 0.001159
p50 latency ms: 0.000173
p90 latency ms: 0.000322
p99 latency ms: 0.005903
Total hits: 6398289
===> GET_NON_EXISTING <===
avg. time ms: 0.000412
std dev ms: 0.001178
p50 latency ms: 0.000172
p90 latency ms: 0.000331
p99 latency ms: 0.005983
Total hits: 1598783
===> SET <===
avg. time ms: 0.000425
std dev ms: 0.001189
p50 latency ms: 0.000181
p90 latency ms: 0.000375
p99 latency ms: 0.006031
Total hits: 2002928
Total hits: 10000000

Also tested using standalone cluster.

Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
@acarbonetto acarbonetto force-pushed the java/dev_acarbo_jedi_threadpool branch from ab9013d to 46896e6 Compare February 15, 2024 23:15
@acarbonetto acarbonetto force-pushed the java/integ_acarbo_jedi_threadpool branch from 1dc2483 to 26e7a0b Compare February 15, 2024 23:17
Signed-off-by: Andrew Carbonetto <[email protected]>
@acarbonetto acarbonetto merged commit 82be845 into java/integ_acarbo_jedi_threadpool Feb 16, 2024
10 checks passed
Yury-Fridlyand pushed a commit that referenced this pull request Feb 27, 2024
* Update jedis sync client with thread pooling (#86)

* Add jedis threadpool for standalone client

Signed-off-by: Andrew Carbonetto <[email protected]>

---------

Signed-off-by: Andrew Carbonetto <[email protected]>

* Java-Jedis: Only set the pool for standalone

Signed-off-by: Andrew Carbonetto <[email protected]>

* Spotless

Signed-off-by: Andrew Carbonetto <[email protected]>

* Rename field in jedis client

Signed-off-by: Andrew Carbonetto <[email protected]>

---------

Signed-off-by: Andrew Carbonetto <[email protected]>
cyip10 pushed a commit that referenced this pull request Jun 24, 2024
* Update jedis sync client with thread pooling (#86)

* Add jedis threadpool for standalone client

Signed-off-by: Andrew Carbonetto <[email protected]>

---------

Signed-off-by: Andrew Carbonetto <[email protected]>

* Java-Jedis: Only set the pool for standalone

Signed-off-by: Andrew Carbonetto <[email protected]>

* Spotless

Signed-off-by: Andrew Carbonetto <[email protected]>

* Rename field in jedis client

Signed-off-by: Andrew Carbonetto <[email protected]>

---------

Signed-off-by: Andrew Carbonetto <[email protected]>
@Yury-Fridlyand Yury-Fridlyand deleted the java/dev_acarbo_jedi_threadpool branch July 19, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants