Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jedis sync client with thread pooling #86

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -6,18 +6,24 @@
import java.util.Set;
import redis.clients.jedis.DefaultJedisClientConfig;
import redis.clients.jedis.HostAndPort;
import redis.clients.jedis.Jedis;
import redis.clients.jedis.JedisCluster;
import redis.clients.jedis.JedisPool;
import redis.clients.jedis.commands.JedisCommands;

/** A Jedis client with sync capabilities. See: https://github.com/redis/jedis */
public class JedisClient implements SyncClient {

private JedisCommands jedis;
boolean isClusterMode;
private JedisPool jedisPool;
private JedisCluster jedisCluster;

@Override
public void closeConnection() {
// nothing to do
if (jedisCluster != null) {
jedisCluster.close();
}
if (jedisPool != null) {
jedisPool.close();
}
}

@Override
Expand All @@ -27,27 +33,36 @@ public String getName() {

@Override
public void connectToRedis(ConnectionSettings connectionSettings) {
if (connectionSettings.clusterMode) {
jedis =
isClusterMode = connectionSettings.clusterMode;
if (isClusterMode) {
jedisCluster =
new JedisCluster(
Set.of(new HostAndPort(connectionSettings.host, connectionSettings.port)),
DefaultJedisClientConfig.builder().ssl(connectionSettings.useSsl).build());
} else {
try (JedisPool pool =
new JedisPool(
connectionSettings.host, connectionSettings.port, connectionSettings.useSsl)) {
jedis = pool.getResource();
}
}
jedisPool =
new JedisPool(connectionSettings.host, connectionSettings.port, connectionSettings.useSsl);
}

@Override
public void set(String key, String value) {
jedis.set(key, value);
if (isClusterMode) {
jedisCluster.set(key, value);
} else {
try (Jedis jedis = jedisPool.getResource()) {
jedis.set(key, value);
}
}
}

@Override
public String get(String key) {
return jedis.get(key);
if (isClusterMode) {
return jedisCluster.get(key);
} else {
try (Jedis jedis = jedisPool.getResource()) {
return jedis.get(key);
}
}
}
}
Loading