charts/portal added usage pod annotation for tls-manager job#381
Open
hakimc76 wants to merge 3 commits into
Open
charts/portal added usage pod annotation for tls-manager job#381hakimc76 wants to merge 3 commits into
hakimc76 wants to merge 3 commits into
Conversation
ksaladi
reviewed
Jun 8, 2025
| backoffLimit: 0 | ||
| template: | ||
| metadata: | ||
| {{- if .Values.apim.podAnnotations }} |
Contributor
There was a problem hiding this comment.
@hakimc76 the if condition should be something like {{- if .Values.jobs.podAnnotations }} so under the values.yaml, podAnnotations should be specified under jobs.
Author
There was a problem hiding this comment.
@ksaladi I have incorporated your suggested adjustment into the files
Contributor
There was a problem hiding this comment.
@hakimc76 we updated stable charts to incorporate the podAnnotations in Portal jobs. So please refer to the stable branch charts/portal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
added usage pod annotation for tls-manager job
Benefits
you can add a pod annaotation to the tls-manager job
Drawbacks
none
Applicable issues
Case #: 36332852
Additional information
We need this for the deployment on AKS
The creation of the secrets fails because the script within the tls-manager job fails because it cannot reach the kubernetes API.
In AKS you need to set the annotation: kubernetes.azure.com/set-kube-service-host-fqdn: ""
Checklist
Chart.yamlaccording to semver.[charts/gateway])values-production.yamlapart fromvalues.yaml, ensure that you implement the changes in both files