Skip to content

charts/portal added usage pod annotation for tls-manager job #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hakimc76 wants to merge 3 commits into
base: stable
Choose a base branch
from
Open

charts/portal added usage pod annotation for tls-manager job #381

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
41685af
added usage pod annotation for tls-manager job
cherr-h Jun 3, 2025
804e12d
bump version
cherr-h Jun 3, 2025
a7747bd
processed review commentary pr #381
cherr-h Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/portal/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
appVersion: "5.3.2"
description: CA API Developer Portal
name: portal
version: 2.3.14
version: 2.3.15
type: application
home: https://github.com/CAAPIM/apim-charts
maintainers:
Expand Down
4 changes: 4 additions & 0 deletions charts/portal/templates/jobs/cert-update-job.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@ metadata:
spec:
backoffLimit: 0
template:
metadata:
{{- if .Values.apim.podAnnotations }}
Copy link
Copy Markdown
Contributor

@ksaladi ksaladi Jun 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hakimc76 the if condition should be something like {{- if .Values.jobs.podAnnotations }} so under the values.yaml, podAnnotations should be specified under jobs.

Copy link
Copy Markdown
Author

@hakimc76 hakimc76 Jun 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ksaladi I have incorporated your suggested adjustment into the files

Copy link
Copy Markdown
Contributor

@ksaladi ksaladi Jun 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hakimc76 we updated stable charts to incorporate the podAnnotations in Portal jobs. So please refer to the stable branch charts/portal.

annotations: {{- toYaml .Values.apim.podAnnotations | nindent 8 }}
{{- end }}
spec:
serviceAccountName: {{ include "portal.serviceAccountName" . }}
restartPolicy: Never
Expand Down