Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge from AM3 - params #402

Closed
JhanSrbinovsky opened this issue Sep 17, 2024 · 2 comments · Fixed by #404
Closed

Merge from AM3 - params #402

JhanSrbinovsky opened this issue Sep 17, 2024 · 2 comments · Fixed by #404

Comments

@JhanSrbinovsky
Copy link
Collaborator

JhanSrbinovsky commented Sep 17, 2024 •
edited
Loading

This issue covers the merging of code in params/ and utils/ directory from AM3 development.

Null testing against offline will be required here @ccarouge, how do you want to proceed? I'm pretty sure I did this a month or so ago before moving on to the next part of the merge BUT:

  1. I no longer have the output handy
  2. I still haven't used benchcab, I am still using manual pre-cursor to benchcab variety of testing.

Note: Not that it actually changes anything, but technically it does intersect with all applications of CABLE

The overarching issue concerning AM3 merging is here #403
@JhanSrbinovsky JhanSrbinovsky mentioned this issue Sep 17, 2024
Merged
3 tasks
@JhanSrbinovsky JhanSrbinovsky linked a pull request Sep 17, 2024 that will close this issue
402 merge from am3 params #404
Merged
3 tasks
@ccarouge
Copy link
Member

What is "null testing" ? Is that the same as regression testing?

@JhanSrbinovsky
Copy link
Collaborator Author

I just mean that the regression testing will/should show there is no difference, as expected

@JhanSrbinovsky JhanSrbinovsky mentioned this issue Oct 7, 2024
Closed
@JhanSrbinovsky JhanSrbinovsky mentioned this issue Oct 21, 2024
Merged
JhanSrbinovsky added a commit that referenced this issue Oct 28, 2024
@JhanSrbinovsky
414 merge am3 miscellaneous science modifications (#430)
1717d92 
# CABLE

Thank you for submitting a pull request to the CABLE Project.

## Description

Miscellaneous developments in science/ dir. from AM3. These are included
separately to more major developments in canopy and soilsnow
directories.

Fixes #402

## Type of change

Including AM3 development.

## Checklist

- [X ] The new content is accessible and located in the appropriate
section.
- [ X] I have checked that links are valid and point to the intended
content.
- [ X] I have checked my code/text and corrected any misspellings

<!-- readthedocs-preview cable start -->
----
📚 Documentation preview 📚:
https://cable--430.org.readthedocs.build/en/430/

<!-- readthedocs-preview cable end -->
@JhanSrbinovsky JhanSrbinovsky mentioned this issue Oct 29, 2024
Closed
3 tasks
JhanSrbinovsky added a commit that referenced this issue Nov 6, 2024
@JhanSrbinovsky @ccarouge
402 merge from am3 params (#404)
a5a52d8 
# CABLE

Thank you for submitting a pull request to the CABLE Project.

## Description

Merge modifications made during in AM3 development. 

You can link issues by using a supported keyword in the pull request's
description or in a commit message:

Fixes #402 

## Type of change

Merge modifications made during in AM3 development. 

## Testing:
benchcab regression testing against `main` show no changes.

## Checklist

- [X] The new content is accessible and located in the appropriate
section.
- [X] I have checked that links are valid and point to the intended
content.
- [X] I have checked my code/text and corrected any misspellings



<!-- readthedocs-preview cable start -->
----
📚 Documentation preview 📚:
https://cable--404.org.readthedocs.build/en/404/

<!-- readthedocs-preview cable end -->

---------

Co-authored-by: Claire Carouge <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

402 merge from am3 params CABLE-LSM/CABLE
2 participants
@JhanSrbinovsky @ccarouge