-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
414 merge am3 miscellaneous science modifications #430
414 merge am3 miscellaneous science modifications #430
Conversation
…eous-science-modifications
off and ICE density used that has changed as well
Not ready to submit for merge as dependent on preceding merge of #402, params |
Note: comparison here is to branch #402 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay but I think we've gone backwards with the changes to the spitter
call - Needs checking.
One last thing - did you look at the benchcab analysis? I couldn't really make any sense of it. Some slightly better, some slightly worse it seemed. |
DOH!! Because of the lag in submitting these to main, and they are all sequential , and somewhat dependent on the previous tranche of developments, I branched this (or at least compared it to the pre-ceding, related issue #402 ). Unfortunately this hadn't gone through, I hadn't remembered weeks later that I had "compared" to the 402 branch in this PR and so when merging was approved/executed - it went back to the params branch. In the interim I have addressed the comments about cable_surface_types in #436. This PR will/should go through fairly quickly. Regardless, I need to, it will be cleaner if I rebase from main post #436 going in AND then re-submit this PR. |
CABLE
Thank you for submitting a pull request to the CABLE Project.
Description
Miscellaneous developments in science/ dir. from AM3. These are included separately to more major developments in canopy and soilsnow directories.
Fixes #402
Type of change
Including AM3 development.
Checklist
📚 Documentation preview 📚: https://cable--430.org.readthedocs.build/en/430/