-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Appropriately handle race unknown #196
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #196 +/- ##
=======================================
Coverage 97.65% 97.65%
=======================================
Files 32 32
Lines 1576 1576
=======================================
Hits 1539 1539
Misses 37 37 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bamader would you mind adding another test or two for this, the existing test doesn't account for ASKED_UNKNOWN. It also be good to assert that the other races are still being used appropriately.
@ericbuckley No problem, some test cases added to test for other races as well as ASKED_UNKNOWN |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR removes the
feature_iter
yield for theRACE
field whenever an incoming record has a value for that field ofUNKNOWN
orASKED_UNKNOWN
. This ensures that, downstream, we don't perform fuzzy string comparisons against known race values andUNKNOWN
and thereby award some log odds points where none should be.Related Issues
#193
Additional Notes
n/a
<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->
Checklist
Please review and complete the following checklist before submitting your pull request:
Checklist for Reviewers
Please review and complete the following checklist during the review process: