Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appropriately handle race unknown #196

Merged
merged 4 commits into from
Feb 7, 2025
Merged

Appropriately handle race unknown #196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
41389d6
Appropriately handle race unknown
bamader Feb 6, 2025
b51a21e
Empty list not none
bamader Feb 6, 2025
769d2ec
Add some more test cases
bamader Feb 7, 2025
0582e82
Change enum type to string in test
bamader Feb 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/recordlinker/schemas/pii.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ def feature_iter(self, feature: Feature) -> typing.Iterator[str]:
if name.family:
yield name.family
elif attribute == FeatureAttribute.RACE:
if self.race:
if self.race and self.race not in [Race.UNKNOWN, Race.ASKED_UNKNOWN]:
yield str(self.race)
elif attribute == FeatureAttribute.TELECOM:
for telecom in self.telecom:
Expand Down
16 changes: 15 additions & 1 deletion tests/unit/schemas/test_pii.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,8 @@ def test_parse_race(self):
assert record.race == pii.Race.BLACK
record = pii.PIIRecord(race="native hawaiian or other pacific islander")
assert record.race == pii.Race.HAWAIIAN
record = pii.PIIRecord(race="asked unknown")
assert record.race == pii.Race.ASKED_UNKNOWN
record = pii.PIIRecord(race="asked but unknown")
assert record.race == pii.Race.ASKED_UNKNOWN
record = pii.PIIRecord(race="unknown")
Expand Down Expand Up @@ -242,7 +244,7 @@ def test_feature_iter(self):
assert list(record.feature_iter(pii.Feature(attribute=pii.FeatureAttribute.GIVEN_NAME))) == ["John", "L", "Jane"]
assert list(record.feature_iter(pii.Feature(attribute=pii.FeatureAttribute.FIRST_NAME))) == ["John", "Jane"]
assert list(record.feature_iter(pii.Feature(attribute=pii.FeatureAttribute.LAST_NAME))) == ["Doe", "Smith"]
assert list(record.feature_iter(pii.Feature(attribute=pii.FeatureAttribute.RACE))) == ["UNKNOWN"]
assert list(record.feature_iter(pii.Feature(attribute=pii.FeatureAttribute.RACE))) == []
assert list(record.feature_iter(pii.Feature(attribute=pii.FeatureAttribute.TELECOM))) == [
"555-123-4567",
"(555) 987-6543",
Expand All @@ -257,6 +259,18 @@ def test_feature_iter(self):
# IDENTIFIER with suffix
assert list(record.feature_iter(pii.Feature(attribute=pii.FeatureAttribute.IDENTIFIER, suffix="MR"))) == ["MR::123456"]
assert list(record.feature_iter(pii.Feature(attribute=pii.FeatureAttribute.IDENTIFIER, suffix="SS"))) == ["SS::123-45-6789"]

# Other fields work okay, few more checks on difference race yield values
record = pii.PIIRecord(race="asked unknown")
assert list(record.feature_iter(pii.Feature(attribute=pii.FeatureAttribute.RACE))) == []
record = pii.PIIRecord(race="asked but unknown")
assert list(record.feature_iter(pii.Feature(attribute=pii.FeatureAttribute.RACE))) == []
record = pii.PIIRecord(race="asian")
assert list(record.feature_iter(pii.Feature(attribute=pii.FeatureAttribute.RACE))) == ["ASIAN"]
record = pii.PIIRecord(race="african american")
assert list(record.feature_iter(pii.Feature(attribute=pii.FeatureAttribute.RACE))) == ["BLACK"]
record = pii.PIIRecord(race="white")
assert list(record.feature_iter(pii.Feature(attribute=pii.FeatureAttribute.RACE))) == ["WHITE"]


def test_blocking_keys_invalid(self):
Expand Down
Loading