Skip to content

Final admin dashboard changes #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 32 commits into from
Sep 2, 2024
Merged

Conversation

EarthenSky
Copy link
Collaborator

@EarthenSky EarthenSky commented Aug 22, 2024

For #2
Related to CSSS/csss-site-frontend#62 and CSSS/csss-site-frontend#51

changes

  • small bugfixes
  • take in list for /new_term endpoint

@EarthenSky EarthenSky marked this pull request as ready for review August 22, 2024 17:02
@EarthenSky
Copy link
Collaborator Author

EarthenSky commented Aug 24, 2024

Changes

  • ...
  • remove is_filled_out field from tables & main migration
  • refactor methods so that uploaded data does not include data computed by the backend
  • (in-progress) perform data validation in /officers/{computing_id}/update_info endpoint, using google & discord APIs

TODOs

  • test locally using a discord token for the CSSS site server with readonly access
  • test locally using a google drive token for the CSSS google drives
  • how to see the hidden google drive for execs only & make sure that permissions are being updated correctly? I guess csss-site should have the information for which drives are private & their IDs should be on the old server
  • test locally using a github token

@micahdbak
Copy link
Collaborator

Done or naw?

* add basic google drive api usage

* finish off lightweight google api module
@EarthenSky
Copy link
Collaborator Author

EarthenSky commented Sep 1, 2024

Done or naw?

Nope, but getting close!! I've done enough research into how the google drive api works to know that we only need to attempt to assign the user to their permission to check if their email is valid. I'm thinking I'll leave stronger permission checks for later though (#82).

TODOs

  • access term by term_id
  • change endpoints to take computing id as a path parameter
  • make sure the up[date function validates inputs like with update_info

@EarthenSky
Copy link
Collaborator Author

Oh dear, I was hoping something like this wouldn't happen again; breaking things into smaller PRs is going to be a goal in the future!

Changes

  • a list of new officer terms can be created in a single transaction (for the admin page)

  • daily cron support was merged here from Update officer permissions daily #72 (but that feature is still not done yet)

  • many small bug fixes

  • reformat github module

  • add extra github functions for getting permissions

  • add google drive module & add functions for getting & setting drive permissions (TODO in Update officer permissions daily #72)

  • reformat discord module

  • add extra functions to discord module for listing

  • add integration tests for the discord, github, and google modules, plus documentation for running them under the wiki. I've also tested several of these on prod to ensure they work!

  • add email module that has not been tested

  • add auth/info endpoint for getting current user's info

  • add GET officers/info/{computing_id} endpoint for getting private officer info

  • remove is_filled_in column from officer tables

  • add PATCH officers/info/{computing_id} endpoint for updating officer info

  • add PATCH officers/term/{term_id} endpoint for updating officer term id

  • lots of refactoring so that code is mostly dry

@EarthenSky EarthenSky merged commit 0aac756 into main Sep 2, 2024
2 checks passed
@EarthenSky
Copy link
Collaborator Author

"move fast and break things"

@EarthenSky EarthenSky deleted the dev-final-admin-dashboard-changes branch September 2, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants