Skip to content

User profile page (+ officer info input) #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 2, 2024
Merged

Conversation

EarthenSky
Copy link
Contributor

@EarthenSky EarthenSky commented Aug 23, 2024

Close #8 and CSSS/csss-site-backend#76 (i suppose)

This PR adds the /profile page, which, when a user has been selected as an officer, stores officer information that needs to be input.

@EarthenSky EarthenSky force-pushed the dev-officer-input-page branch from 9b06d01 to 8a1baca Compare August 23, 2024 02:38
@EarthenSky EarthenSky mentioned this pull request Aug 23, 2024
@EarthenSky EarthenSky changed the title Officer Input Page User profile page (+ officer info input) Aug 23, 2024
@EarthenSky
Copy link
Contributor Author

EarthenSky commented Aug 23, 2024

Surely we'll make it visually consistent one day...

Recording.2024-08-22.221210_USER.PROFILE.mp4

@EarthenSky
Copy link
Contributor Author

Screenshot 2024-08-24 003235

@micahdbak micahdbak marked this pull request as ready for review August 31, 2024 06:25
Copy link
Collaborator

@micahdbak micahdbak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love

Is it ready

I approve

Merge when u want

HECK YES

@micahdbak micahdbak linked an issue Aug 31, 2024 that may be closed by this pull request
@micahdbak
Copy link
Collaborator

Looks like this PR already uses /api, so that's good! Triple check for me tho, pls

@micahdbak
Copy link
Collaborator

@EarthenSky - just merged main - please pull and confirm everything works with your backend - then merge pls

@EarthenSky
Copy link
Contributor Author

EarthenSky commented Sep 2, 2024

Screenshot 2024-09-01 171826

Officer info is complete.

TODOs

  • add an input for officer term data, and stop users from modifying term data that's not current

@EarthenSky EarthenSky marked this pull request as draft September 2, 2024 00:20
@EarthenSky EarthenSky marked this pull request as ready for review September 2, 2024 19:45
@EarthenSky
Copy link
Contributor Author

This PR is getting big (like CSSS/csss-site-backend#70), so I'll finish the interface for officer term in a separate PR (issue CSSS/csss-site-backend#84).

@EarthenSky EarthenSky merged commit a4037b5 into main Sep 2, 2024
@EarthenSky EarthenSky deleted the dev-officer-input-page branch September 2, 2024 19:46
@EarthenSky EarthenSky mentioned this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a edit profile page create frontend page for executives to input their info
2 participants