Support for custom url path #948
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you @radmirnovii. Can we reuse |
Author
|
Contributor
Yes. Web context should be also considered for health check like Apologize for holding your PR for so long, I'll merge the 2 PRs with minor changes maybe, once I got load balancing performance issue fixed :< |
radmirnovii
force-pushed
the
custom_url_path
branch
from
1146aed to
6db2a31
Compare
radmirnovii
force-pushed
the
custom_url_path
branch
from
6db2a31 to
33f9d09
Compare
Contributor
|
Fixed in #956 along with some more tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Useful with http proxy. Previous version in
ru.yandex.clickhousehas this feature with option USE_PATH_AS_DB=false.current driver has WEB_CONTEXT option but it used only with trailing slash