Skip to content

Set output as background #3079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 21, 2025
Merged

Set output as background #3079

merged 5 commits into from
May 21, 2025

Conversation

christian-byrne
Copy link
Contributor

@christian-byrne christian-byrne commented Mar 16, 2025

output-as-bg.mp4

Needs discussion.

It's become considerably more difficult to set custom BG image since change to shipping comfy frontend as a pypi package.

┆Issue is synchronized with this Notion page by Unito

@christian-byrne
Copy link
Contributor Author

Better approach: keep a setting field for the background image, show some sort of visual indication of how to "unset" the background if it was set form the queue right click context menu.

@christian-byrne
Copy link
Contributor Author

Changes:

  • Move the background image to a field in the settings
  • Can still be changed with right click in queue sidebar
  • Reloads color palette when the settings changes

Demo:

set-as-background-v2-demo-.mp4

Let's merge this!

Copy link
Contributor

@webfiltered webfiltered left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you noticed any performance issues? Specifically with a large busy graph, or zooming in on a long link?

Not extremely concerned, just want to make sure there aren't any single-digit FPS issues popping up from the transparent canvas.

@christian-byrne
Copy link
Contributor Author

Good question, let me test a bit and report back.

@christian-byrne
Copy link
Contributor Author

After testing some images of various sizes, I was not able to find any scenarios with noticeable performance differences compared with default background.

@huchenlei huchenlei merged commit 49400c6 into main May 21, 2025
10 checks passed
@huchenlei huchenlei deleted the output-to-bg branch May 21, 2025 16:15
christian-byrne added a commit that referenced this pull request May 22, 2025
Co-authored-by: github-actions <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants