-
Notifications
You must be signed in to change notification settings - Fork 280
Set output as background #3079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set output as background #3079
Conversation
Better approach: keep a setting field for the background image, show some sort of visual indication of how to "unset" the background if it was set form the queue right click context menu. |
218d610
to
8e8eeb4
Compare
Changes:
Demo: set-as-background-v2-demo-.mp4Let's merge this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you noticed any performance issues? Specifically with a large busy graph, or zooming in on a long link?
Not extremely concerned, just want to make sure there aren't any single-digit FPS issues popping up from the transparent canvas.
Good question, let me test a bit and report back. |
After testing some images of various sizes, I was not able to find any scenarios with noticeable performance differences compared with default background. |
Co-authored-by: github-actions <[email protected]>
output-as-bg.mp4
Needs discussion.
It's become considerably more difficult to set custom BG image since change to shipping comfy frontend as a pypi package.
┆Issue is synchronized with this Notion page by Unito