Configure dda feature flags variables #43279
Merged
+20
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team/agent-devx
short review
Contributor
Gitlab CI Configuration Changes
|
| Removed | Modified | Added | Renamed |
|---|---|---|---|
| 0 | 15 | 0 | 0 |
ℹ️ Diff available in the job log.
Contributor
Static quality checks✅ Please find below the results from static quality gates Successful checksInfo
|
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: e157462 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | -0.01 | [-2.91, +2.89] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | quality_gate_logs | % cpu utilization | +1.17 | [-0.31, +2.65] | 1 | Logs bounds checks dashboard |
| ➖ | otlp_ingest_logs | memory utilization | +0.69 | [+0.58, +0.79] | 1 | Logs |
| ➖ | ddot_logs | memory utilization | +0.25 | [+0.18, +0.32] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | +0.23 | [-0.00, +0.46] | 1 | Logs |
| ➖ | otlp_ingest_metrics | memory utilization | +0.21 | [+0.07, +0.35] | 1 | Logs |
| ➖ | ddot_metrics | memory utilization | +0.19 | [-0.03, +0.41] | 1 | Logs |
| ➖ | file_tree | memory utilization | +0.11 | [+0.06, +0.16] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | +0.05 | [-0.34, +0.44] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.02 | [-0.39, +0.44] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | +0.01 | [-0.36, +0.39] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | +0.01 | [-0.04, +0.05] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.12, +0.13] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.09, +0.09] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_v3 | ingress throughput | -0.00 | [-0.12, +0.12] | 1 | Logs |
| ➖ | docker_containers_cpu | % cpu utilization | -0.01 | [-2.91, +2.89] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | -0.02 | [-0.06, +0.03] | 1 | Logs bounds checks dashboard |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | -0.17 | [-0.22, -0.12] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | -0.21 | [-0.26, -0.16] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_metrics_logs | memory utilization | -0.31 | [-0.51, -0.10] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | -0.59 | [-0.73, -0.45] | 1 | Logs |
| ➖ | ddot_metrics_sum_delta | memory utilization | -0.60 | [-0.79, -0.40] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -0.86 | [-0.94, -0.79] | 1 | Logs |
| ➖ | docker_containers_memory | memory utilization | -1.73 | [-1.89, -1.57] | 1 | Logs |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
KevinFairise2
force-pushed
the
kfairise/configure-agent-ci-for-ff
branch
from
57b7ad7 to
9d79a36
Compare
github-actions
bot
added
medium review
KevinFairise2
force-pushed
the
kfairise/configure-agent-ci-for-ff
branch
from
19b488d to
d81b444
Compare
KevinFairise2
added
changelog/no-changelog
qa/no-code-change
CelianR
approved these changes
Nov 21, 2025
Co-authored-by: Célian Raimbault <[email protected]>
alexn-dd
approved these changes
Nov 21, 2025
Member
Author
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
The expected merge time in
|
rdesgroppes
approved these changes
Nov 21, 2025
Co-authored-by: Régis Desgroppes <[email protected]>
rdesgroppes
added a commit
that referenced
this pull request
Nov 27, 2025
### What does this PR do? Simplifies environment variable passing to Docker containers in Windows CI jobs by using `-e VAR` instead of `-e VAR=$VAR` or `-e VAR="$VAR"`. ### Motivation Following the introduction of `-e CI` in 642e324 (#43279), this PR cleans up redundant variable passing syntax across all Windows CI jobs. Docker's `-e` flag automatically passes environment variables from the host when only the variable name is provided, making the `=$VAR` syntax redundant. This simplifies the configuration and makes it easier to read. Reference: https://docs.docker.com/reference/cli/docker/container/run/ ### Changes - Simplified ~50+ environment variable declarations across 7 GitLab CI files: - `.gitlab/binary_build/windows.yml` - `.gitlab/choco_build/choco_build.yml` - `.gitlab/deploy_packages/winget.yml` - `.gitlab/integration_test/windows.yml` - `.gitlab/lint/windows.yml` - `.gitlab/package_build/windows.yml` - `.gitlab/source_test/windows.yml` - Preserved legitimate cases where variable names differ from values: - `-e TARGET_ARCH="$ARCH"` - `-e GOMODCACHE="c:\modcache"` - `-e OMNIBUS_GIT_CACHE_DIR=${Env:TEMP}/...` ### Describe how you validated your changes - Code review: verified all simplified variables are standard GitLab CI or AWS environment variables that should be passed through as-is - Docker documentation confirms `-e VAR` syntax is supported and recommended 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
rdesgroppes
added a commit
that referenced
this pull request
Nov 28, 2025
### What does this PR do? Simplifies environment variable passing to Docker containers in Windows CI jobs by using `-e VAR` instead of `-e VAR=$VAR` or `-e VAR="$VAR"`. ### Motivation Following the introduction of `-e CI` in 642e324 (#43279), this PR cleans up redundant variable passing syntax across all Windows CI jobs. Docker's `-e` flag automatically passes environment variables from the host when only the variable name is provided, making the `=$VAR` syntax redundant. This simplifies the configuration and makes it easier to read. Reference: https://docs.docker.com/reference/cli/docker/container/run/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add required variables in the CI to benefits from
ddafeature flags.https://datadoghq.dev/datadog-agent-dev/how-to/feature-flags/ci/
Motivation
Be able to leverage feature flag to rollout more gradually CI tasks updates
Describe how you validated your changes
Ran a pipeline with some calls to
dda featurefor example: https://gitlab.ddbuild.io/DataDog/datadog-agent/-/jobs/1249938012#L429Additional Notes