Simplify environment variable passing to Docker containers in CI #43590
+89
−89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdesgroppes
added
changelog/no-changelog
qa/no-code-change
Contributor
Gitlab CI Configuration Changes
|
| Removed | Modified | Added | Renamed |
|---|---|---|---|
| 0 | 21 | 0 | 0 |
Updated: .gitlab/trigger_distribution/include.yml
Modified Jobs
publish_winget_7_x64
publish_winget_7_x64:
before_script:
- $tmpfile = [System.IO.Path]::GetTempFileName()
- (& "$CI_PROJECT_DIR\tools\ci\fetch_secret.ps1" -parameterName "$Env:WINGET_PAT"
-tempFile "$tmpfile")
- If ($lastExitCode -ne "0") { exit "$lastExitCode" }
- $wingetPat=$(cat "$tmpfile")
- Remove-Item "$tmpfile"
dependencies: []
rules:
- if: $BUCKET_BRANCH != "beta" && $BUCKET_BRANCH != "stable"
when: never
- allow_failure: true
when: manual
script:
- $ErrorActionPreference = "Stop"
- 'docker run --rm -v "$(Get-Location):c:\mnt" -e WINGET_GITHUB_ACCESS_TOKEN=${wingetPat}
+ -e GENERAL_ARTIFACTS_CACHE_BUCKET_URL ${WINBUILDIMAGE} Powershell -C "C:\mnt\tasks\winbuildscripts\Update-Winget.ps1"
- -e GENERAL_ARTIFACTS_CACHE_BUCKET_URL=${GENERAL_ARTIFACTS_CACHE_BUCKET_URL} ${WINBUILDIMAGE}
- Powershell -C "C:\mnt\tasks\winbuildscripts\Update-Winget.ps1"
'
- If ($lastExitCode -ne "0") { throw "Previous command returned $lastExitCode" }
stage: deploy_packages
tags:
- windows-v2:2022
variables:
ARCH: x64
OVERRIDE_GIT_STRATEGY: clone
WINBUILDIMAGE: registry.ddbuild.io/ci/datadog-agent-buildimages/windows_ltsc2022_${ARCH}${CI_IMAGE_WIN_LTSC2022_X64_SUFFIX}:${CI_IMAGE_WIN_LTSC2022_X64}Changes Summary
| Removed | Modified | Added | Renamed |
|---|---|---|---|
| 0 | 1 | 0 | 0 |
ℹ️ Diff available in the job log.
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 427de80 Optimization Goals: ✅ Improvement(s) detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | -3.57 | [-6.44, -0.71] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ✅ | tcp_syslog_to_blackhole | ingress throughput | +11.49 | [+11.41, +11.56] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.01 | [-0.07, +0.08] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_v3 | ingress throughput | +0.00 | [-0.12, +0.12] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.02 | [-0.14, +0.11] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | -0.15 | [-0.54, +0.24] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.18 | [-0.60, +0.23] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | -0.19 | [-0.24, -0.15] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | -0.20 | [-0.73, +0.33] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | -0.55 | [-0.78, -0.32] | 1 | Logs |
| ➖ | ddot_metrics | memory utilization | -0.65 | [-0.84, -0.46] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | -0.79 | [-0.95, -0.64] | 1 | Logs |
| ➖ | ddot_metrics_sum_delta | memory utilization | -1.21 | [-1.41, -1.01] | 1 | Logs |
| ➖ | ddot_logs | memory utilization | -1.31 | [-1.37, -1.25] | 1 | Logs |
| ➖ | docker_containers_memory | memory utilization | -1.86 | [-1.94, -1.77] | 1 | Logs |
| ➖ | file_tree | memory utilization | -2.38 | [-2.43, -2.33] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | -2.38 | [-2.43, -2.33] | 1 | Logs bounds checks dashboard |
| ➖ | otlp_ingest_metrics | memory utilization | -2.80 | [-2.93, -2.66] | 1 | Logs |
| ➖ | otlp_ingest_logs | memory utilization | -3.07 | [-3.17, -2.98] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | -3.26 | [-3.31, -3.21] | 1 | Logs bounds checks dashboard |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | -3.40 | [-3.46, -3.35] | 1 | Logs |
| ➖ | docker_containers_cpu | % cpu utilization | -3.57 | [-6.44, -0.71] | 1 | Logs |
| ✅ | quality_gate_metrics_logs | memory utilization | -6.05 | [-6.26, -5.83] | 1 | Logs bounds checks dashboard |
| ✅ | quality_gate_logs | % cpu utilization | -18.26 | [-19.61, -16.92] | 1 | Logs bounds checks dashboard |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
Contributor
Static quality checks✅ Please find below the results from static quality gates Successful checksInfo
|
### What does this PR do? Simplifies environment variable passing to Docker containers in Windows CI jobs by using `-e VAR` instead of `-e VAR=$VAR` or `-e VAR="$VAR"`. ### Motivation Following the introduction of `-e CI` in 642e324 (#43279), this PR cleans up redundant variable passing syntax across all Windows CI jobs. Docker's `-e` flag automatically passes environment variables from the host when only the variable name is provided, making the `=$VAR` syntax redundant. This simplifies the configuration and makes it easier to read. Reference: https://docs.docker.com/reference/cli/docker/container/run/
rdesgroppes
force-pushed
the
regis.desgroppes/simplify-docker-env-vars
branch
from
9b1bd79 to
4c229bb
Compare
rdesgroppes
changed the title
This was referenced Nov 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Simplify environment variable passing to Docker containers in CI jobs by using
-e VARinstead of-e VAR=${VAR}.Motivation
See:
bazelconfiguration in CI #43274 (comment)Docker's
-e/--envflags automatically pass environment variables from the host when only the variable name is provided (passthrough), making the=$VARsyntax redundant. This simplifies the configuration and makes it less errorprone.Reference: https://docs.docker.com/reference/cli/docker/container/run/