-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
benchmarks: Use 1 Warmup Interation and ensure opcache is used #2531
Conversation
BenchmarksBenchmark execution time: 2024-02-23 11:22:48 Comparing candidate commit 4257a5e in PR branch Found 35 performance improvements and 2 performance regressions! Performance is the same for 144 metrics, 1 unstable metrics. scenario:ContextPropagationBench/benchExtractHeaders128Bit
scenario:ContextPropagationBench/benchExtractHeaders128Bit-opcache
scenario:ContextPropagationBench/benchExtractHeaders64Bit
scenario:ContextPropagationBench/benchExtractHeaders64Bit-opcache
scenario:ContextPropagationBench/benchExtractTraceContext128Bit
scenario:ContextPropagationBench/benchExtractTraceContext128Bit-opcache
scenario:ContextPropagationBench/benchExtractTraceContext64Bit
scenario:ContextPropagationBench/benchExtractTraceContext64Bit-opcache
scenario:ContextPropagationBench/benchInject128Bit-opcache
scenario:EmptyFileBench/benchEmptyFileBaseline
scenario:EmptyFileBench/benchEmptyFileBaseline-opcache
scenario:EmptyFileBench/benchEmptyFileOverhead
scenario:EmptyFileBench/benchEmptyFileOverhead-opcache
scenario:LaravelBench/benchLaravelBaseline
scenario:LaravelBench/benchLaravelBaseline-opcache
scenario:LaravelBench/benchLaravelOverhead
scenario:LaravelBench/benchLaravelOverhead-opcache
scenario:LogsInjectionBench/benchLogsInfoBaseline
scenario:LogsInjectionBench/benchLogsInfoBaseline-opcache
scenario:LogsInjectionBench/benchLogsInfoInjection-opcache
scenario:LogsInjectionBench/benchLogsNullBaseline-opcache
scenario:LogsInjectionBench/benchLogsNullInjection
scenario:LogsInjectionBench/benchLogsNullInjection-opcache
scenario:MessagePackSerializationBench/benchMessagePackSerialization
scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache
scenario:SamplingRuleMatchingBench/benchRegexMatching3-opcache
scenario:SamplingRuleMatchingBench/benchRegexMatching4-opcache
scenario:SymfonyBench/benchSymfonyBaseline
scenario:SymfonyBench/benchSymfonyBaseline-opcache
scenario:SymfonyBench/benchSymfonyOverhead
scenario:SymfonyBench/benchSymfonyOverhead-opcache
scenario:WordPressBench/benchEnhancedWordPressOverhead
scenario:WordPressBench/benchEnhancedWordPressOverhead-opcache
scenario:WordPressBench/benchWordPressBaseline
scenario:WordPressBench/benchWordPressBaseline-opcache
scenario:WordPressBench/benchWordPressOverhead
scenario:WordPressBench/benchWordPressOverhead-opcache
|
db770e4
to
a47228d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see 20%-60% perf improvement, I approve!
a47228d
to
f027eeb
Compare
f027eeb
to
4257a5e
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2531 +/- ##
============================================
+ Coverage 76.55% 78.74% +2.19%
Complexity 267 267
============================================
Files 138 112 -26
Lines 17459 13485 -3974
Branches 976 0 -976
============================================
- Hits 13365 10619 -2746
+ Misses 3574 2866 -708
+ Partials 520 0 -520
Flags with carried forward coverage won't be shown. Click here to find out more. see 26 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
(cherry picked from commit 527e4d9)
Description
Native profiles when:
These profiles assess that opcache is indeed used in web requests. What's more, the warmups seemingly responsible for improvements in both kinds of benchmarks, because the first run will be longer since DD_AUTOLOAD_NO_COMPILE is used.
Reviewer checklist