Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(langchain): mark flaky test #12190

Merged
merged 3 commits into from
Feb 7, 2025
Merged

ci(langchain): mark flaky test #12190

merged 3 commits into from
Feb 7, 2025
+40 −0

Conversation

sabrenner
Copy link
Contributor

@sabrenner sabrenner commented Jan 31, 2025 •
edited by Yun-Kim
Loading

Marking a flaky test for main. This test will be removed entirely in deprecation once the 3.x-staging branch is merged.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@sabrenner sabrenner marked this pull request as ready for review January 31, 2025 16:53
@sabrenner sabrenner requested a review from a team as a code owner January 31, 2025 16:53
@github-actions GitHub Actions
Copy link
Contributor

CODEOWNERS have been resolved as:

tests/contrib/langchain/test_langchain.py                               @DataDog/ml-observability

@Yun-Kim Yun-Kim added the changelog/no-changelog A changelog entry is not required for this PR. label Jan 31, 2025
@sabrenner sabrenner enabled auto-merge (squash) January 31, 2025 16:55
@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: sabrenner/langchain-flaky
Commit report: 30e3ddf
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1468 Skipped, 5m 10.69s Total duration (35m 31.45s time saved)

@Yun-Kim Yun-Kim mentioned this pull request Jan 31, 2025
Closed
2 tasks
@pr-commenter
Copy link

pr-commenter bot commented Jan 31, 2025 •
edited
Loading

Benchmarks

Benchmark execution time: 2025-02-05 13:55:39

Comparing candidate commit 32c3347 in PR branch sabrenner/langchain-flaky with baseline commit af9098c in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

brettlangdon
brettlangdon reviewed Feb 3, 2025
View reviewed changes
Copy link
Member

@brettlangdon brettlangdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the errors are showing that it cannot pull the model being used in this test, does that just need to be updated?

@brettlangdon brettlangdon changed the base branch from main to 3.x-staging February 3, 2025 17:02
@brettlangdon brettlangdon requested review from a team as code owners February 3, 2025 17:02
@brettlangdon brettlangdon changed the base branch from 3.x-staging to main February 3, 2025 17:02
@sabrenner
Copy link
Contributor Author

yeah something weird is going on with this one in particular, but we're re-working our dependencies for these tests in general to make them less flaky 👍 other tests were skipped in #12194

@brettlangdon
Copy link
Member

cool, since main is locked now, we can probably close this PR since 3.x-staging will become the new main soon.

@brettlangdon brettlangdon enabled auto-merge (squash) February 5, 2025 14:48
@erikayasuda erikayasuda force-pushed the main branch 2 times, most recently from 1247ac2 to 2ccaaef Compare February 6, 2025 20:43
@erikayasuda erikayasuda changed the base branch from main to 2.20 February 7, 2025 11:57
@erikayasuda erikayasuda requested review from a team as code owners February 7, 2025 11:57
@erikayasuda erikayasuda changed the base branch from 2.20 to 2.x February 7, 2025 11:57
@erikayasuda erikayasuda marked this pull request as draft February 7, 2025 11:58
auto-merge was automatically disabled February 7, 2025 11:58

Pull request was converted to draft

@brettlangdon brettlangdon changed the base branch from 2.x to 2.20 February 7, 2025 15:49
@brettlangdon brettlangdon changed the base branch from 2.20 to 2.x February 7, 2025 15:50
@brettlangdon brettlangdon marked this pull request as ready for review February 7, 2025 15:50
@brettlangdon brettlangdon merged commit 898e38c into 2.x Feb 7, 2025
286 checks passed
@brettlangdon brettlangdon deleted the sabrenner/langchain-flaky branch February 7, 2025 15:53
github-actions bot pushed a commit that referenced this pull request Feb 7, 2025
@sabrenner @github-actions
ci(langchain): mark flaky test (#12190)
e338ccf 
Marking a flaky test for `main`. This test will be removed entirely in
deprecation once the `3.x-staging` branch is merged.

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit 898e38c)
@github-actions github-actions bot mentioned this pull request Feb 7, 2025
Open
2 tasks
github-actions bot pushed a commit that referenced this pull request Feb 7, 2025
@sabrenner @github-actions
ci(langchain): mark flaky test (#12190)
27411b1 
Marking a flaky test for `main`. This test will be removed entirely in
deprecation once the `3.x-staging` branch is merged.

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit 898e38c)
@github-actions github-actions bot mentioned this pull request Feb 7, 2025
Open
2 tasks
github-actions bot pushed a commit that referenced this pull request Feb 7, 2025
@sabrenner @github-actions
ci(langchain): mark flaky test (#12190)
59c6326 
Marking a flaky test for `main`. This test will be removed entirely in
deprecation once the `3.x-staging` branch is merged.

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit 898e38c)
@github-actions github-actions bot mentioned this pull request Feb 7, 2025
Merged
2 tasks
brettlangdon pushed a commit that referenced this pull request Feb 7, 2025
@github-actions @sabrenner
ci(langchain): mark flaky test [backport 2.20] (#12259)
a251d35 
Backport 898e38c from #12190 to 2.20.

Marking a flaky test for `main`. This test will be removed entirely in
deprecation once the `3.x-staging` branch is merged.

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

Co-authored-by: Sam Brenner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettlangdon brettlangdon brettlangdon left review comments

@emmettbutler emmettbutler emmettbutler approved these changes

@Kyle-Verhoog Kyle-Verhoog Kyle-Verhoog approved these changes

@Yun-Kim Yun-Kim Yun-Kim approved these changes

@vitor-de-araujo vitor-de-araujo vitor-de-araujo approved these changes

Assignees
No one assigned
Labels
backport 2.18 backport 2.19 backport 2.20 changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@sabrenner @brettlangdon @Yun-Kim @emmettbutler @Kyle-Verhoog @vitor-de-araujo @lievan @erikayasuda