Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: skip current flaky tests #12194

Merged
merged 3 commits into from
Feb 3, 2025
Merged

ci: skip current flaky tests #12194

merged 3 commits into from
Feb 3, 2025

Conversation

gnufede
Copy link
Member

@gnufede gnufede commented Feb 3, 2025

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@gnufede gnufede added the CI label Feb 3, 2025
@gnufede gnufede requested a review from a team as a code owner February 3, 2025 10:15
Copy link
Contributor

github-actions bot commented Feb 3, 2025

CODEOWNERS have been resolved as:

tests/contrib/langchain/test_langchain.py                               @DataDog/ml-observability

@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: gnufede/flaky-tests
Commit report: 1902a89
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1468 Skipped, 4m 48.34s Total duration (35m 44.3s time saved)

@gnufede gnufede added the changelog/no-changelog A changelog entry is not required for this PR. label Feb 3, 2025
@pr-commenter
Copy link

pr-commenter bot commented Feb 3, 2025

Benchmarks

Benchmark execution time: 2025-02-03 11:35:25

Comparing candidate commit c732d2b in PR branch gnufede/flaky-tests with baseline commit 7257296 in branch 3.x-staging.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

@gnufede gnufede enabled auto-merge (squash) February 3, 2025 12:20
@gnufede gnufede merged commit 7ec9f6a into 3.x-staging Feb 3, 2025
208 of 209 checks passed
@gnufede gnufede deleted the gnufede/flaky-tests branch February 3, 2025 15:28
@sabrenner sabrenner mentioned this pull request Feb 3, 2025
2 tasks
gnufede added a commit that referenced this pull request Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR. CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants