-
Notifications
You must be signed in to change notification settings - Fork 437
fix(llmobs): reuse shared conn #13339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 234 ± 3 ms. The average import time from base is: 235 ± 2 ms. The import time difference between this PR and base is: -0.8 ± 0.1 ms. Import time breakdownThe following import paths have shrunk:
|
fa940f2
to
31c134a
Compare
BenchmarksBenchmark execution time: 2025-05-06 23:31:11 Comparing candidate commit 3fdca66 in PR branch Found 0 performance improvements and 2 performance regressions! Performance is the same for 506 metrics, 4 unstable metrics. scenario:iast_aspects-format_map_aspect
scenario:iast_aspects-ospathsplitdrive_aspect
|
7fedfed
to
cd7be33
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a thought about the change in logs and the implication it might have. It'd also be good to have a better validation than logs for successful transmission but that's a bit larger of an ask outside the scope here
Co-authored-by: IAL32 <[email protected]>
cd7be33
to
3fdca66
Compare
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.21 2.21
# Navigate to the new working tree
cd .worktrees/backport-2.21
# Create a new branch
git switch --create backport-13339-to-2.21
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 479699d87a4794d808d854435f3df6ba0e83fb33
# Push it to GitHub
git push --set-upstream origin backport-13339-to-2.21
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.21 Then, create a pull request where the |
Resolves #13336. Credit to @IAL32 and a cherry-pick from #13338.
When we made the jump from using the shared HTTPWriter to our own BaseLLMObsWriter class to submit spans and evals #12966, we used our own
_get_connection()
to return HTTP/HTTPS connections. However we forgot to include UDSHTTP connection (for the unix socket case), which means we broke UDS support until now.Why was this a problem in the first place?
We used our own
_get_connection()
in #12966 because of an issue where creating the shared HTTPConnection helper class was leading to MRO superclass constructor issues in our tests. At the time we thought this was due to the shared HTTPConnection helper class having multiple superclasses and an issue with Python 3.10 in general, but this turns out to be due to vcrpy mocking HTTPConnection entirely and only being an issue in tests that rely on vcrpy. This PR makes some changes to avoid using vcrpy when not necessary, and making better assertions to ensure that spans are being sent (not necessary in most tests to have them be accepted).Checklist
Reviewer Checklist