Skip to content

Comments

fix(symdb): switch _shallow to shallow in install#13522

Merged
tylfin merged 1 commit intomainfrom
tyler.finethy/DEBUG-3687
May 28, 2025
Merged

fix(symdb): switch _shallow to shallow in install#13522
tylfin merged 1 commit intomainfrom
tyler.finethy/DEBUG-3687

Conversation

@tylfin
Copy link
Member

@tylfin tylfin commented May 28, 2025

This fixes a bug introduced by #12957 where the shallow mode for SymDB was introduced.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@github-actions
Copy link
Contributor

github-actions bot commented May 28, 2025

CODEOWNERS have been resolved as:

releasenotes/notes/fix-symdb-uploads-cfff7f4d568ff882.yaml              @DataDog/apm-python
ddtrace/internal/symbol_db/symbols.py                                   @DataDog/debugger-python
tests/internal/symbol_db/test_symbols.py                                @DataDog/debugger-python

@tylfin tylfin force-pushed the tyler.finethy/DEBUG-3687 branch from 12c31f3 to 776994a Compare May 28, 2025 14:26
@tylfin tylfin requested a review from ojung May 28, 2025 14:26
@tylfin tylfin force-pushed the tyler.finethy/DEBUG-3687 branch from 776994a to d1bd354 Compare May 28, 2025 14:26
@tylfin tylfin force-pushed the tyler.finethy/DEBUG-3687 branch from d1bd354 to 7ea53af Compare May 28, 2025 14:32
@github-actions
Copy link
Contributor

github-actions bot commented May 28, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 232 ± 2 ms.

The average import time from base is: 234 ± 2 ms.

The import time difference between this PR and base is: -2.2 ± 0.1 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 1.995 ms (0.86%)
ddtrace.bootstrap.sitecustomize 1.321 ms (0.57%)
ddtrace.bootstrap.preload 1.321 ms (0.57%)
ddtrace.internal.remoteconfig.client 0.640 ms (0.28%)
ddtrace 0.674 ms (0.29%)
ddtrace.internal._unpatched 0.023 ms (0.01%)

@tylfin tylfin changed the title fix(symdb): switch _shallow to shallow in install fix(symdb): switch _shallow to shallow in install May 28, 2025
@tylfin tylfin marked this pull request as ready for review May 28, 2025 14:53
@tylfin tylfin requested review from a team as code owners May 28, 2025 14:53
@tylfin tylfin requested review from ZStriker19 and nsrip-dd May 28, 2025 14:53
@pr-commenter
Copy link

pr-commenter bot commented May 28, 2025

Benchmarks

Benchmark execution time: 2025-05-28 15:19:57

Comparing candidate commit 7ea53af in PR branch tyler.finethy/DEBUG-3687 with baseline commit 3eaf6a8 in branch main.

Found 0 performance improvements and 4 performance regressions! Performance is the same for 345 metrics, 5 unstable metrics.

scenario:iast_aspects-ospathdirname_aspect

  • 🟥 execution_time [+694.454ns; +934.928ns] or [+14.771%; +19.886%]

scenario:iast_aspects-ospathjoin_aspect

  • 🟥 execution_time [+0.961µs; +1.157µs] or [+15.581%; +18.762%]

scenario:iast_aspects-ospathnormcase_aspect

  • 🟥 execution_time [+449.339ns; +523.669ns] or [+12.964%; +15.109%]

scenario:iast_aspects-ospathsplit_aspect

  • 🟥 execution_time [+680.887ns; +906.232ns] or [+14.041%; +18.688%]

@tylfin tylfin merged commit 58bd69c into main May 28, 2025
299 of 302 checks passed
@tylfin tylfin deleted the tyler.finethy/DEBUG-3687 branch May 28, 2025 17:03
@github-actions
Copy link
Contributor

The backport to 2.21 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.21 2.21
# Navigate to the new working tree
cd .worktrees/backport-2.21
# Create a new branch
git switch --create backport-13522-to-2.21
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 58bd69c5e0273349ebecc09c0d382a4e742ef2a5
# Push it to GitHub
git push --set-upstream origin backport-13522-to-2.21
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.21

Then, create a pull request where the base branch is 2.21 and the compare/head branch is backport-13522-to-2.21.

github-actions bot pushed a commit that referenced this pull request May 28, 2025
This fixes a bug introduced by
#12957 where the shallow mode
for SymDB was introduced.

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit 58bd69c)
tylfin added a commit that referenced this pull request May 29, 2025
…13528)

Backport 58bd69c from #13522 to 3.8.

This fixes a bug introduced by
#12957 where the shallow mode
for SymDB was introduced.

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

Co-authored-by: Tyler Finethy <tylfin@gmail.com>
Co-authored-by: Emmett Butler <723615+emmettbutler@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants