Fix AppSec libddwaf actions handling after update to 1.17.0.0.0 #4173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In version 1.17.0.0.0 libddwaf changes the format of the actions that are returned from an array of actions IDs to an array of actions objects. This means that we no longer have to look up actions in the ruleset and can just use actions that libddwaf returns.
Datadog ReportBranch report: ✅ 0 Failed, 22028 Passed, 1458 Skipped, 5m 31.88s Total Time |
y9v
force-pushed
the
appsec-fix-libddwaf-actions-handling
branch
from
fb14384 to
315c32f
Compare
BenchmarksBenchmark execution time: 2024-11-28 16:26:35 Comparing candidate commit fb14384 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4173 +/- ##
==========================================
- Coverage 97.78% 97.76% -0.02%
==========================================
Files 1353 1351 -2
Lines 81861 81732 -129
Branches 4153 4146 -7
==========================================
- Hits 80044 79904 -140
- Misses 1817 1828 +11 ☔ View full report in Codecov by Sentry. |
marcotc
approved these changes
Nov 28, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In version 1.17.0.0.0 libddwaf changes the format of the actions that are returned from an array of actions IDs to an array of actions objects. This means that we no longer have to look up actions in the ruleset and can just use actions that libddwaf returns.
https://github.com/DataDog/libddwaf/blob/master/UPGRADING.md#action-semantics
What does this PR do?
This PR removes
AppSec::Actionsclass, since we don't need to hold and lookup ruleset actions now, libddwaf does it for us. It also fixes custom action handling inDatadog::AppSec::Response.Motivation:
Failing system tests that test blocking using custom actions:
#4171
Change log entry
None
Additional Notes:
None
How to test the change?
CI is enough (system tests have to be run from
cbeauchesne/add-system-tests-scenariobranch)